🏠 Add instrumentation test for Suggestions BottomSheet

chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.suggestions;
+
+import android.os.SystemClock;
+import android.support.test.filters.MediumTest;
+import android.view.MotionEvent;
+
+import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;
+import org.chromium.chrome.test.BottomSheetTestCaseBase;
+import org.chromium.content.browser.test.util.TestTouchUtils;
+
+/**
+ * Tests for the behaviour of the suggestions bottom sheet content.

[Michael van Ouwerkerk, 2017/02/03 20:20:33]

How about this? "Instrumentation tests for {@code
SuggestionsBottomSheetContent}."

[dgn, 2017/02/06 16:45:17]

Done.

+ */
+public class SuggestionsBottomSheetTest extends BottomSheetTestCaseBase {
+    @MediumTest
+    public void testContextMenu() throws InterruptedException {
+        // TODO(dgn): set the initial adapter content to avoid network dependent behaviour.
+        NewTabPageRecyclerView recyclerView = getRecyclerView();
+        assertFalse(recyclerView.onInterceptTouchEvent(createTap()));
+
+        TestTouchUtils.longClickView(getInstrumentation(), recyclerView.findFirstCard().itemView);

[Michael van Ouwerkerk, 2017/02/03 20:20:33]

Do we know for sure that the first card has been rendered at this point? I ran
into lots of edge cases around that, see NewTabPageRecyclerViewTest#waitForView.

[dgn, 2017/02/06 16:45:18]

Done.

+        assertTrue(recyclerView.onInterceptTouchEvent(createTap()));
+
+        getActivity().closeContextMenu();
+        assertFalse(recyclerView.onInterceptTouchEvent(createTap()));
+    }
+
+    private static MotionEvent createTap() {

[Michael van Ouwerkerk, 2017/02/03 20:20:33]

Maybe "createTapEvent"?

[dgn, 2017/02/06 16:45:18]

Done.

+        return MotionEvent.obtain(SystemClock.uptimeMillis(), SystemClock.uptimeMillis(),
+                MotionEvent.ACTION_DOWN, 0f, 0f, 0);
+    }
+
+    private NewTabPageRecyclerView getRecyclerView() {
+        return (NewTabPageRecyclerView) getBottomSheetContent().getScrollingContentView();
+    }
+}