Encode inlining information in CodeSourceMap and remove inlining interval arrays.

Encode inlining information in CodeSourceMap and remove inlining interval arrays.

CodeSourceMap now contains a small bytecode that describes changes to the token position and inlining stack as one moves through a function. This information is used by the disassembler to display inlining comments and by the profiler to properly blame ticks against source code.

Slightly shrinks the total size of code metadata; on dart2js compiling hello world, the final heap is

 before 59.6MB total, 12.8MB List, 1.1MB CodeSourceMap
  after 59.4MB total, 12.1MB List, 1.5MB CodeSourceMap

To be filtered and included in AOT code to expand inline frames in stack traces.

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/909ce02b124430bc452dc8822107dd4f5f92c784

[rmacnak, 2017-02-06 21:10:30]

Description was changed from

==========
CodeSourceMap
==========

to

==========
Encode inlining information in CodeSourceMap and remove inlining interval
arrays.

CodeSourceMap now contains a small bytecode that describes changes to the token
position and inlining stack as one moves through a function. This information is
used by the disassembler to display inlining comments and by the profiler to
properly blame ticks against source code.

To be filtered and included in AOT code to expand inline frames in stack traces.
==========

[rmacnak, 2017-02-06 21:10:45]

Description was changed from

==========
Encode inlining information in CodeSourceMap and remove inlining interval
arrays.

CodeSourceMap now contains a small bytecode that describes changes to the token
position and inlining stack as one moves through a function. This information is
used by the disassembler to display inlining comments and by the profiler to
properly blame ticks against source code.

To be filtered and included in AOT code to expand inline frames in stack traces.
==========

to

==========
Encode inlining information in CodeSourceMap and remove inlining interval
arrays.

CodeSourceMap now contains a small bytecode that describes changes to the token
position and inlining stack as one moves through a function. This information is
used by the disassembler to display inlining comments and by the profiler to
properly blame ticks against source code.

To be filtered and included in AOT code to expand inline frames in stack traces.
==========

[rmacnak, 2017-02-06 21:42:31]

Description was changed from

==========
Encode inlining information in CodeSourceMap and remove inlining interval
arrays.

CodeSourceMap now contains a small bytecode that describes changes to the token
position and inlining stack as one moves through a function. This information is
used by the disassembler to display inlining comments and by the profiler to
properly blame ticks against source code.

To be filtered and included in AOT code to expand inline frames in stack traces.
==========

to

==========
Encode inlining information in CodeSourceMap and remove inlining interval
arrays.

CodeSourceMap now contains a small bytecode that describes changes to the token
position and inlining stack as one moves through a function. This information is
used by the disassembler to display inlining comments and by the profiler to
properly blame ticks against source code.

Slightly shrinks the total size of code metadata; on dart2js compiling hello
world, the final heap is

 before 59.6MB total, 12.8MB List, 1.1MB CodeSourceMap
  after 59.4MB total, 12.1MB List, 1.5MB CodeSourceMap

To be filtered and included in AOT code to expand inline frames in stack traces.
==========

[rmacnak, 2017-02-06 22:00:59]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2017-02-07 17:14:24]

https://codereview.chromium.org/2670843006/diff/120001/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/2670843006/diff/120001/runtime/vm/flow_graph_...
runtime/vm/flow_graph_compiler.cc:1052: // Force simulation through the last pc
offset.
what is this doing?

https://codereview.chromium.org/2670843006/diff/120001/runtime/vm/profiler_se...
File runtime/vm/profiler_service.cc (right):

https://codereview.chromium.org/2670843006/diff/120001/runtime/vm/profiler_se...
runtime/vm/profiler_service.cc:1610: (inlined_functions->length() <= 1)) {
shouldn't the inlined functions length == 0 in the case there are no inlined
functions?

[rmacnak, 2017-02-07 18:04:13]

Replies also added comments in the code.

https://codereview.chromium.org/2670843006/diff/120001/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/2670843006/diff/120001/runtime/vm/flow_graph_...
runtime/vm/flow_graph_compiler.cc:1052: // Force simulation through the last pc
offset.
On 2017/02/07 17:14:24, Cutch wrote:
> what is this doing?

This checks we can decode the CodeSourceMap. E.g., simulate to the end without
hitting an unknown opcode, stack underflow, etc.

https://codereview.chromium.org/2670843006/diff/120001/runtime/vm/profiler_se...
File runtime/vm/profiler_service.cc (right):

https://codereview.chromium.org/2670843006/diff/120001/runtime/vm/profiler_se...
runtime/vm/profiler_service.cc:1610: (inlined_functions->length() <= 1)) {
On 2017/02/07 17:14:24, Cutch wrote:
> shouldn't the inlined functions length == 0 in the case there are no inlined
> functions?

The inlined function list includes the root function as the first element, so
unoptimized code or optimized code without inlining will have a list of length
1. The list will be empty if we lack a CodeSourceMap, in stub code.

[Cutch, 2017-02-07 18:27:05]

This is nice!

LGTM

https://codereview.chromium.org/2670843006/diff/140001/runtime/vm/code_descri...
File runtime/vm/code_descriptors.h (right):

https://codereview.chromium.org/2670843006/diff/140001/runtime/vm/code_descri...
runtime/vm/code_descriptors.h:149: static const TokenPosition kInitialPosition;
Maybe comment that this is the seed token position and represents the prologue
of the function...

[rmacnak, 2017-02-07 20:50:45]

https://codereview.chromium.org/2670843006/diff/140001/runtime/vm/code_descri...
File runtime/vm/code_descriptors.h (right):

https://codereview.chromium.org/2670843006/diff/140001/runtime/vm/code_descri...
runtime/vm/code_descriptors.h:149: static const TokenPosition kInitialPosition;
On 2017/02/07 18:27:04, Cutch wrote:
> Maybe comment that this is the seed token position and represents the prologue
> of the function...

Done.

[rmacnak, 2017-02-07 20:52:26]

Description was changed from

==========
Encode inlining information in CodeSourceMap and remove inlining interval
arrays.

CodeSourceMap now contains a small bytecode that describes changes to the token
position and inlining stack as one moves through a function. This information is
used by the disassembler to display inlining comments and by the profiler to
properly blame ticks against source code.

Slightly shrinks the total size of code metadata; on dart2js compiling hello
world, the final heap is

 before 59.6MB total, 12.8MB List, 1.1MB CodeSourceMap
  after 59.4MB total, 12.1MB List, 1.5MB CodeSourceMap

To be filtered and included in AOT code to expand inline frames in stack traces.
==========

to

==========
Encode inlining information in CodeSourceMap and remove inlining interval
arrays.

CodeSourceMap now contains a small bytecode that describes changes to the token
position and inlining stack as one moves through a function. This information is
used by the disassembler to display inlining comments and by the profiler to
properly blame ticks against source code.

Slightly shrinks the total size of code metadata; on dart2js compiling hello
world, the final heap is

 before 59.6MB total, 12.8MB List, 1.1MB CodeSourceMap
  after 59.4MB total, 12.1MB List, 1.5MB CodeSourceMap

To be filtered and included in AOT code to expand inline frames in stack traces.

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/909ce02b124430bc452dc8822107dd4f5f92c784
==========

[rmacnak, 2017-02-07 20:52:28]

Committed patchset #9 (id:160001) manually as
909ce02b124430bc452dc8822107dd4f5f92c784 (presubmit successful).