Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2670843004: Record defined top-level/class-mebber names with unlinked bundles. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Record defined top-level/class-mebber names with unlinked bundles. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8326ae9640978dbbe6fa3f3991fc20ecc050b9f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -5 lines) Patch
A pkg/analyzer/lib/src/dart/analysis/defined_names.dart View 1 chunk +53 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 5 chunks +23 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 8 chunks +74 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +12 lines, -0 lines 0 comments Download
A pkg/analyzer/test/src/dart/analysis/defined_names_test.dart View 1 chunk +58 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/file_state_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-02 17:16:15 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-02 17:24:06 UTC) #2
scheglov
3 years, 10 months ago (2017-02-02 17:51:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8326ae9640978dbbe6fa3f3991fc20ecc050b9f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698