Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: src/code-stubs.h

Issue 2670843002: [stubs] Also port the CallICStub to CSA. (Closed)
Patch Set: Introduce FullCodeGenerator::IntFromSlot. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 1d26e28fec3a5ca6dced2b1ec192309601317205..97939a8551d190141d1cff2b9b0041677280fbd2 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -865,7 +865,7 @@ class ArrayConstructorStub: public PlatformCodeStub {
void GenerateDispatchToArrayStub(MacroAssembler* masm,
AllocationSiteOverrideMode mode);
- DEFINE_CALL_INTERFACE_DESCRIPTOR(ArrayNArgumentsConstructor);
+ DEFINE_CALL_INTERFACE_DESCRIPTOR(ArrayConstructor);
DEFINE_PLATFORM_CODE_STUB(ArrayConstructor, PlatformCodeStub);
};
@@ -913,12 +913,11 @@ class MathPowStub: public PlatformCodeStub {
DEFINE_PLATFORM_CODE_STUB(MathPow, PlatformCodeStub);
};
-
-class CallICStub: public PlatformCodeStub {
+class CallICStub : public TurboFanCodeStub {
public:
CallICStub(Isolate* isolate, ConvertReceiverMode convert_mode,
TailCallMode tail_call_mode)
- : PlatformCodeStub(isolate) {
+ : TurboFanCodeStub(isolate) {
minor_key_ = ConvertModeBits::encode(convert_mode) |
TailCallModeBits::encode(tail_call_mode);
}
@@ -940,15 +939,11 @@ class CallICStub: public PlatformCodeStub {
return TailCallModeBits::decode(minor_key_);
}
- // Code generation helpers.
- void GenerateMiss(MacroAssembler* masm);
- void HandleArrayCase(MacroAssembler* masm, Label* miss);
-
private:
- void PrintState(std::ostream& os) const override; // NOLINT
+ void PrintState(std::ostream& os) const final; // NOLINT
- DEFINE_CALL_INTERFACE_DESCRIPTOR(CallFunctionWithFeedbackAndVector);
- DEFINE_PLATFORM_CODE_STUB(CallIC, PlatformCodeStub);
+ DEFINE_CALL_INTERFACE_DESCRIPTOR(CallIC);
+ DEFINE_TURBOFAN_CODE_STUB(CallIC, TurboFanCodeStub);
};
@@ -1631,7 +1626,7 @@ class CallICTrampolineStub : public TurboFanCodeStub {
private:
void PrintState(std::ostream& os) const override; // NOLINT
- DEFINE_CALL_INTERFACE_DESCRIPTOR(CallFunctionWithFeedback);
+ DEFINE_CALL_INTERFACE_DESCRIPTOR(CallICTrampoline);
DEFINE_TURBOFAN_CODE_STUB(CallICTrampoline, TurboFanCodeStub);
};
« no previous file with comments | « src/code-factory.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698