Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2915)

Unified Diff: android_webview/BUILD.gn

Issue 2670833004: Use a depfile to know when to regenerate notice files (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/tools/webview_licenses.py » ('j') | android_webview/tools/webview_licenses.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/BUILD.gn
diff --git a/android_webview/BUILD.gn b/android_webview/BUILD.gn
index 0e7bb13febf83e58e469caba503f87b561875adf..6737a713dab4ae80e8a9d32ee80aa594d26f0c50 100644
--- a/android_webview/BUILD.gn
+++ b/android_webview/BUILD.gn
@@ -149,16 +149,18 @@ android_assets("assets") {
action("generate_webview_license_notice") {
script = "tools/webview_licenses.py"
- inputs = exec_script("//android_webview/tools/webview_licenses.py",
- [ "gn_notice_deps" ],
- "value")
- inputs += [ "tools/licenses_notice.tmpl" ]
+ depfile = "$target_gen_dir/$target_name.d"
+ inputs = [
+ "tools/licenses_notice.tmpl",
+ ]
outputs = [
webview_license_path,
]
args = [
"notice",
- rebase_path(webview_license_path),
+ rebase_path(webview_license_path, root_build_dir),
+ "--depfile",
+ rebase_path(depfile, root_build_dir),
]
}
« no previous file with comments | « no previous file | android_webview/tools/webview_licenses.py » ('j') | android_webview/tools/webview_licenses.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698