test/cctest/test-debug.cc - Issue 2670823002: [debugger] remove mirror cache and v8::Debug::GetMirror.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-debug.cc

Issue 2670823002: [debugger] remove mirror cache and v8::Debug::GetMirror. (Closed)

Patch Set: address comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-debug.cc

diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc

index e053a4e604d71be5c10799679970c3e85fabe7ea..ce069884cb699499a00c337d311d1a125284fb71 100644

--- a/test/cctest/test-debug.cc

+++ b/test/cctest/test-debug.cc

@@ -4422,7 +4422,7 @@ TEST(HiddenPrototypePropertyMirror) {

.FromJust());

// The prototype (__proto__) for o0 should be o3 as o1 and o2 are hidden.

- CHECK(CompileRun("o0_mirror.protoObject() == o3_mirror")

+ CHECK(CompileRun("o0_mirror.protoObject().value() == o3_mirror.value()")

->BooleanValue(context)

.FromJust());

}

« no previous file with comments | « src/inspector/debugger_script_externs.js ('k') | test/mjsunit/regress/regress-618608.js » ('j') | no next file with comments »