Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: test/cctest/test-debug.cc

Issue 2670823002: [debugger] remove mirror cache and v8::Debug::GetMirror. (Closed)
Patch Set: address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/inspector/debugger_script_externs.js ('k') | test/mjsunit/regress/regress-618608.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4404 matching lines...) Expand 10 before | Expand all | Expand 10 after
4415 ->Int32Value(context) 4415 ->Int32Value(context)
4416 .FromJust()); 4416 .FromJust());
4417 CHECK_EQ(2, CompileRun("o0_mirror.property('z').value().value()") 4417 CHECK_EQ(2, CompileRun("o0_mirror.property('z').value().value()")
4418 ->Int32Value(context) 4418 ->Int32Value(context)
4419 .FromJust()); 4419 .FromJust());
4420 CHECK(CompileRun("o0_mirror.property('u').isUndefined()") 4420 CHECK(CompileRun("o0_mirror.property('u').isUndefined()")
4421 ->BooleanValue(context) 4421 ->BooleanValue(context)
4422 .FromJust()); 4422 .FromJust());
4423 4423
4424 // The prototype (__proto__) for o0 should be o3 as o1 and o2 are hidden. 4424 // The prototype (__proto__) for o0 should be o3 as o1 and o2 are hidden.
4425 CHECK(CompileRun("o0_mirror.protoObject() == o3_mirror") 4425 CHECK(CompileRun("o0_mirror.protoObject().value() == o3_mirror.value()")
4426 ->BooleanValue(context) 4426 ->BooleanValue(context)
4427 .FromJust()); 4427 .FromJust());
4428 } 4428 }
4429 4429
4430 4430
4431 static void ProtperyXNativeGetter( 4431 static void ProtperyXNativeGetter(
4432 v8::Local<v8::String> property, 4432 v8::Local<v8::String> property,
4433 const v8::PropertyCallbackInfo<v8::Value>& info) { 4433 const v8::PropertyCallbackInfo<v8::Value>& info) {
4434 info.GetReturnValue().Set(10); 4434 info.GetReturnValue().Set(10);
4435 } 4435 }
(...skipping 2216 matching lines...) Expand 10 before | Expand all | Expand 10 after
6652 reinterpret_cast<void*>(isolate)); 6652 reinterpret_cast<void*>(isolate));
6653 CHECK(!out_of_memory_callback_called); 6653 CHECK(!out_of_memory_callback_called);
6654 // The following allocation fails unless the out-of-memory callback 6654 // The following allocation fails unless the out-of-memory callback
6655 // increases the heap limit. 6655 // increases the heap limit.
6656 int length = 10 * i::MB / i::kPointerSize; 6656 int length = 10 * i::MB / i::kPointerSize;
6657 i_isolate->factory()->NewFixedArray(length, i::TENURED); 6657 i_isolate->factory()->NewFixedArray(length, i::TENURED);
6658 CHECK(out_of_memory_callback_called); 6658 CHECK(out_of_memory_callback_called);
6659 } 6659 }
6660 isolate->Dispose(); 6660 isolate->Dispose();
6661 } 6661 }
OLDNEW
« no previous file with comments | « src/inspector/debugger_script_externs.js ('k') | test/mjsunit/regress/regress-618608.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698