Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: src/debug/debug.js

Issue 2670823002: [debugger] remove mirror cache and v8::Debug::GetMirror. (Closed)
Patch Set: address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug.cc ('k') | src/debug/mirrors.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function (global, utils) { 5 (function (global, utils) {
6 "use strict"; 6 "use strict";
7 7
8 // ---------------------------------------------------------------------------- 8 // ----------------------------------------------------------------------------
9 // Imports 9 // Imports
10 10
11 var FrameMirror = global.FrameMirror; 11 var FrameMirror = global.FrameMirror;
12 var GlobalArray = global.Array; 12 var GlobalArray = global.Array;
13 var GlobalRegExp = global.RegExp; 13 var GlobalRegExp = global.RegExp;
14 var IsNaN = global.isNaN; 14 var IsNaN = global.isNaN;
15 var LookupMirror = global.LookupMirror;
16 var MakeMirror = global.MakeMirror; 15 var MakeMirror = global.MakeMirror;
17 var MathMin = global.Math.min; 16 var MathMin = global.Math.min;
18 var Mirror = global.Mirror; 17 var Mirror = global.Mirror;
19 var MirrorType;
20 var ParseInt = global.parseInt;
21 var ValueMirror = global.ValueMirror; 18 var ValueMirror = global.ValueMirror;
22 19
23 utils.Import(function(from) {
24 MirrorType = from.MirrorType;
25 });
26
27 //---------------------------------------------------------------------------- 20 //----------------------------------------------------------------------------
28 21
29 // Default number of frames to include in the response to backtrace request. 22 // Default number of frames to include in the response to backtrace request.
30 var kDefaultBacktraceLength = 10; 23 var kDefaultBacktraceLength = 10;
31 24
32 var Debug = {}; 25 var Debug = {};
33 26
34 // Regular expression to skip "crud" at the beginning of a source line which is 27 // Regular expression to skip "crud" at the beginning of a source line which is
35 // not really code. Currently the regular expression matches whitespace and 28 // not really code. Currently the regular expression matches whitespace and
36 // comments. 29 // comments.
(...skipping 991 matching lines...) Expand 10 before | Expand all | Expand 10 after
1028 utils.InstallFunctions(utils, DONT_ENUM, [ 1021 utils.InstallFunctions(utils, DONT_ENUM, [
1029 "MakeExecutionState", MakeExecutionState, 1022 "MakeExecutionState", MakeExecutionState,
1030 "MakeExceptionEvent", MakeExceptionEvent, 1023 "MakeExceptionEvent", MakeExceptionEvent,
1031 "MakeBreakEvent", MakeBreakEvent, 1024 "MakeBreakEvent", MakeBreakEvent,
1032 "MakeCompileEvent", MakeCompileEvent, 1025 "MakeCompileEvent", MakeCompileEvent,
1033 "MakeAsyncTaskEvent", MakeAsyncTaskEvent, 1026 "MakeAsyncTaskEvent", MakeAsyncTaskEvent,
1034 "IsBreakPointTriggered", IsBreakPointTriggered, 1027 "IsBreakPointTriggered", IsBreakPointTriggered,
1035 ]); 1028 ]);
1036 1029
1037 }) 1030 })
OLDNEW
« no previous file with comments | « src/debug/debug.cc ('k') | src/debug/mirrors.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698