Print stack traces of tests timing out on Windows

Print stack traces of tests timing out on Windows

Uses cdb.exe (part of Windows SDK, comes with depot_tools) to dump stack traces of all threads when a test times out similar
to what we already do on Linux and MacOS.

Note that cdb.exe comes in two version (32- and 64-bit). For proper stacktraces the correct version must be in the PATH.

Fixes #28242.

R=kustermann@google.com

Committed: https://github.com/dart-lang/sdk/commit/d8054eaabe012ddc09d49a01359ea4900cd238a4

[Florian Schneider, 2017-02-02 04:39:30]

Description was changed from

==========
Print stack traces of tests timing out on Windows

Uses windbg to dump stack traces of all threads when a test times out similar
to what we already do on Linux and MacOS.

Fixes #28242.
==========

to

==========
Print stack traces of tests timing out on Windows

Uses cdb.exe (part of Windows SDK, comes with depot_tools) to dump stack traces
of all threads when a test times out similar
to what we already do on Linux and MacOS.

Note that cdb.exe comes in two version (32- and 64-bit). For proper stacktraces
the correct version must be in the PATH.

Fixes #28242.
==========

[Florian Schneider, 2017-02-02 04:40:15]

fschneider@google.com changed reviewers:
+ kustermann@google.com, whesse@google.com

[kustermann, 2017-02-02 13:57:59]

LGTM, very nice!

[kustermann, 2017-02-02 13:59:23]

https://codereview.chromium.org/2670763002/diff/20001/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/2670763002/diff/20001/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:2012: executable = "cdb.exe";
How do you ensure the correct version of cdb.exe is used?

We can modify PATH if we know where the two different versions are.

[Florian Schneider, 2017-02-02 18:22:02]

https://codereview.chromium.org/2670763002/diff/20001/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/2670763002/diff/20001/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:2012: executable = "cdb.exe";
On 2017/02/02 13:59:23, kustermann wrote:
> How do you ensure the correct version of cdb.exe is used?
> 
> We can modify PATH if we know where the two different versions are.

Yes, the correct version has to be in the PATH. I don't want to put any code to
find it here.

[Florian Schneider, 2017-02-02 18:25:36]

Description was changed from

==========
Print stack traces of tests timing out on Windows

Uses cdb.exe (part of Windows SDK, comes with depot_tools) to dump stack traces
of all threads when a test times out similar
to what we already do on Linux and MacOS.

Note that cdb.exe comes in two version (32- and 64-bit). For proper stacktraces
the correct version must be in the PATH.

Fixes #28242.
==========

to

==========
Print stack traces of tests timing out on Windows

Uses cdb.exe (part of Windows SDK, comes with depot_tools) to dump stack traces
of all threads when a test times out similar
to what we already do on Linux and MacOS.

Note that cdb.exe comes in two version (32- and 64-bit). For proper stacktraces
the correct version must be in the PATH.

Fixes #28242.

R=kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d8054eaabe012ddc09d49a01359ea4900cd238a4
==========

[Florian Schneider, 2017-02-02 18:25:37]

Committed patchset #2 (id:20001) manually as
d8054eaabe012ddc09d49a01359ea4900cd238a4 (presubmit successful).