[MD History] Vulcanize as part of GN build.

chrome/browser/resources/md_history/PRESUBMIT.py

Index: chrome/browser/resources/md_history/PRESUBMIT.py
diff --git a/chrome/browser/resources/md_history/PRESUBMIT.py b/chrome/browser/resources/md_history/PRESUBMIT.py
index 8f2ca60f2095074f53b033c810b58bd0d34ea25a..ac646c2bde9d2766541e924861c91d880824c5c4 100644
--- a/chrome/browser/resources/md_history/PRESUBMIT.py
+++ b/chrome/browser/resources/md_history/PRESUBMIT.py
@@ -2,32 +2,6 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-
 def CheckChangeOnUpload(input_api, output_api):
-  """Warn when changing md_history without vulcanizing."""
-
-  def _is_history_source_file(file):
-    path = file.LocalPath()
-    return (not path.endswith('externs.js') and
-            not path.endswith('crisper.js') and
-            not path.endswith('vulcanized.html') and
-            (path.endswith('.js') or path.endswith('.html')))
-
-  os_path = input_api.os_path
-  earliest_vulcanize_change = min(os_path.getmtime(x) for x in
-                                  ['app.vulcanized.html',
-                                   'app.crisper.js',
-                                   'lazy_load.vulcanized.html',
-                                   'lazy_load.crisper.js'])
-
-  source_files = input_api.AffectedFiles(file_filter=_is_history_source_file)
-  latest_history_change = 0
-  if source_files:
-    latest_history_change = max(
-        os_path.getmtime(os_path.basename(f.LocalPath())) for f in source_files)
-
-  if latest_history_change > earliest_vulcanize_change:
-    return [output_api.PresubmitPromptWarning(
-        'Vulcanize must be run when changing files in md_history. See '
-        'docs/vulcanize.md.')]
-  return []
+  return input_api.canned_checks.CheckPatchFormatted(
+      input_api, output_api, check_js=True)

[Dan Beam, 2017/02/08 05:41:55]

might want to do this separately, but i get that it's the only thing left after
removing the vulcanize stuff

[calamity, 2017/02/09 03:07:35]

Lol, so the script here blows up because it expects the generated files to
exist. I could delete this then add the format in the next patch, but I thought
this may as well just happen in one step.