Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2670713004: VM: Don't overwrite stacktrace when rethrowing StackOverflow. (Closed)

Created:
3 years, 10 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/vm/exceptions.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Vyacheslav Egorov (Google)
Florian, Ryan, please take a look.
3 years, 10 months ago (2017-02-03 17:10:57 UTC) #3
Florian Schneider
Lgtm!
3 years, 10 months ago (2017-02-03 17:14:29 UTC) #4
Florian Schneider
dbc: Fixes #24381 as well?
3 years, 10 months ago (2017-02-03 17:25:24 UTC) #5
Vyacheslav Egorov (Google)
Yep. Fixes that one as well. I have finished running tests - landing now.
3 years, 10 months ago (2017-02-03 17:29:27 UTC) #7
Vyacheslav Egorov (Google)
3 years, 10 months ago (2017-02-03 17:30:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab9d5d0e42cbb76831c74cbe208ca7d791df2865 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698