Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2670643006: Skip non-text elements in <a> without href in <figcaption> (Closed)

Created:
3 years, 10 months ago by wychen
Modified:
3 years, 10 months ago
Reviewers:
mdjones
CC:
noyau (Ping after 24h), lody, gambard, olivierrobin
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Skip non-text elements in <a> without href in <figcaption> BUG=688005 R=mdjones@chromium.org Committed: 5da487862e6b079cfc8b8095b5b6fd23c86f20fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M java/org/chromium/distiller/extractors/embeds/ImageExtractor.java View 1 chunk +2 lines, -1 line 0 comments Download
M javatests/org/chromium/distiller/EmbedExtractorTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
wychen
PTAL
3 years, 10 months ago (2017-02-02 16:08:29 UTC) #2
mdjones
lgtm
3 years, 10 months ago (2017-02-02 16:32:35 UTC) #3
wychen
3 years, 10 months ago (2017-02-02 18:03:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5da487862e6b079cfc8b8095b5b6fd23c86f20fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698