Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-rtl.html

Issue 267063007: Fix overconstrained behaviour for position: sticky. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated by review comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-rtl.html
diff --git a/LayoutTests/fast/css/sticky/sticky-top-overflow.html b/LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-rtl.html
similarity index 56%
copy from LayoutTests/fast/css/sticky/sticky-top-overflow.html
copy to LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-rtl.html
index dfda8ae3db7452f59994493c3ebad433e3042c88..57dac7b0f3666dfb408ebb8465a10593b5eaea28 100644
--- a/LayoutTests/fast/css/sticky/sticky-top-overflow.html
+++ b/LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-rtl.html
@@ -1,40 +1,37 @@
<!DOCTYPE html>
+
<html>
<head>
<style>
- .group {
- display: inline-block;
- position: relative;
- width: 150px;
- height: 500px;
- }
-
#overflow {
width: 600px;
- height: 550px;
+ height: 450px;
overflow: hidden; /* Still scrollable with JS */
border: 1px solid black;
}
- .spacer {
- float: left;
- width: 10px;
- height: 1200px;
+ .group {
+ position: relative;
+ width: 500px;
+ height: 150px;
}
+
.container {
- width: 100px;
- height: 400px;
+ width: 400px;
+ height: 130px;
outline: 2px solid black;
+ direction: rtl;
}
.box {
- width: 100px;
- height: 200px;
+ width: 200px;
+ height: 130px;
}
.sticky {
position: sticky;
- top: 100px;
+ left: 600px;
+ right: 100px;
background-color: green;
}
@@ -48,32 +45,31 @@
<script>
function doTest()
{
- document.getElementById('overflow').scrollTop = 120;
+ document.getElementById('overflow').scrollLeft = 100;
}
window.addEventListener('load', doTest, false);
</script>
</head>
<body>
-This test checks that sticky positioned elements are contained by their enclosing ancestor with an overflow clip.
+This test checks that left offset is ignored with overconstrained sticky positioning and rtl text direction.
There should be no red.
<div id="overflow">
- <div class="spacer"></div>
- <div class="group">
- <div class="indicator box" style="top: 200px;"></div>
+ <div class="group" style="left: 400px">
+ <div class="indicator box" style="left: 0;"></div>
<div class="container">
<div class="sticky box"></div>
</div>
</div>
- <div class="group" style="top: 100px">
- <div class="indicator box" style="top: 120px;"></div>
+ <div class="group" style="left: 300px">
+ <div class="indicator box" style="left: 100px;"></div>
<div class="container">
<div class="sticky box"></div>
</div>
</div>
- <div class="group" style="top: 240px">
- <div class="indicator box" style="top: 0;"></div>
+ <div class="group" style="left: 200px">
+ <div class="indicator box" style="left: 200px;"></div>
<div class="container">
<div class="sticky box"></div>
</div>

Powered by Google App Engine
This is Rietveld 408576698