Source/core/page/scrolling/ScrollingConstraints.h - Issue 267063007: Fix overconstrained behaviour for position: sticky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/scrolling/ScrollingConstraints.h

Issue 267063007: Fix overconstrained behaviour for position: sticky. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix logical error in condition. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-rtl-expected.html ('K') | « LayoutTests/fast/css/sticky/sticky-vertically-overconstrained-expected.html ('k') | Source/core/rendering/RenderBoxModelObject.cpp » ('j') | Source/core/rendering/RenderBoxModelObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/scrolling/ScrollingConstraints.h

diff --git a/Source/core/page/scrolling/ScrollingConstraints.h b/Source/core/page/scrolling/ScrollingConstraints.h

index 857430e5a63329e25919cfb16ecc2eccc10e9a69..9c8192415e623e6aaeb4d1b024611bad8decd1bc 100644

--- a/Source/core/page/scrolling/ScrollingConstraints.h

+++ b/Source/core/page/scrolling/ScrollingConstraints.h

@@ -59,6 +59,7 @@ public:

AnchorEdges anchorEdges() const { return m_anchorEdges; }

bool hasAnchorEdge(AnchorEdgeFlags flag) const { return m_anchorEdges & flag; }

void addAnchorEdge(AnchorEdgeFlags edgeFlag) { m_anchorEdges |= edgeFlag; }

+ void removeAnchorEdge(AnchorEdgeFlags edgeFlag) { m_anchorEdges &= ~edgeFlag; }

Julien - ping for review 2014/05/22 15:49:02 This function is unused so it should be removed.

ostap 2014/05/22 23:13:11 Done.

void setAnchorEdges(AnchorEdges edges) { m_anchorEdges = edges; }

FloatSize alignmentOffset() const { return m_alignmentOffset; }