LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-rtl-expected.html - Issue 267063007: Fix overconstrained behaviour for position: sticky.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-rtl-expected.html

Issue 267063007: Fix overconstrained behaviour for position: sticky. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix logical error in condition. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-ltr-expected.html ('K') | « LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-rtl.html ('k') | LayoutTests/fast/css/sticky/sticky-vertically-overconstrained.html » ('j') | Source/core/page/scrolling/ScrollingConstraints.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <html>

	4 <head>

	5 <style>

	6 #overflow {

	7 width: 600px;

	8 height: 600px;

	9 overflow: hidden; /* Still scrollable with JS */

	10 border: 1px solid black;

	11 }

	12

	13 .group {

	14 position: relative;

	15 width: 500px;

	16 height: 200px;

	17 }

	18

	19 .container {

	20 width: 400px;

	21 height: 180px;

	22 outline: 2px solid black;

	23 direction: rtl;

	24 }

	25

	26 .box {

	27 width: 200px;

	28 height: 180px;

	29 }

	30

	31 .sticky {

	32 position: absolute;

	33 background-color: green;

	34 }

	35

	36 .indicator {

	37 position: absolute;

	38 top: 0;

	39 left: 0;

	40 background-color: red;

	41 }

	42 </style>

	43 <script>

	44 function doTest()

	45 {

	46 document.getElementById('overflow').scrollLeft = 100;

	47 }

	48 window.addEventListener('load', doTest, false);

	49 </script>

	50 </head>

	51 <body>

	52 This test checks that left offset is ignored with overconstrained sticky positio ning and rtl text direction.

	53 There should be no red.

	54 <div id="overflow">
	Julien - ping for review 2014/05/22 15:49:02 This overflows the viewport (set to 800x600 in DRT This overflows the viewport (set to 800x600 in DRT) by 2 pixels horizontally (the border) and thus removes some testing space. Fixing it just means to put box-sizing: border-box or fixing your size in the style declaration. ostap 2014/05/22 23:13:11 Done. Show quoted text On 2014/05/22 15:49:02, Julien Chaffraix - CET wrote: > This overflows the viewport (set to 800x600 in DRT) by 2 pixels horizontally > (the border) and thus removes some testing space. Fixing it just means to put > box-sizing: border-box or fixing your size in the style declaration. Done.
	55 <div class="group" style="left: 400px">

	56 <div class="indicator box" style="left: 0;"></div>

	57 <div class="container">

	58 <div class="sticky box" style="left: 0"></div>

	59 </div>

	60 </div>

	61

	62 <div class="group" style="left: 300px">

	63 <div class="indicator box" style="left: 100px;"></div>

	64 <div class="container">

	65 <div class="sticky box" style="left: 100px"></div>

	66 </div>

	67 </div>

	68

	69 <div class="group" style="left: 200px">

	70 <div class="indicator box" style="left: 200px;"></div>

	71 <div class="container">

	72 <div class="sticky box" style="left: 200px"></div>

	73 </div>

	74 </div>

	75 </div>

	76 </body>

	77 </html>

OLD	NEW