Fix overconstrained behaviour for position: sticky.

Source/core/rendering/RenderBoxModelObject.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 311 matching lines @@
     if (!style()->left().isAuto()) {
         constraints.setLeftOffset(floatValueForLength(style()->left(), constrainingRect.width()));
         constraints.addAnchorEdge(ViewportConstraints::AnchorEdgeLeft);
     }
 
     if (!style()->right().isAuto()) {
         constraints.setRightOffset(floatValueForLength(style()->right(), constrainingRect.width()));
         constraints.addAnchorEdge(ViewportConstraints::AnchorEdgeRight);
     }
 
+    float offsetsSum = constraints.rightOffset() + constraints.leftOffset();

[Julien - ping for review, 2014/05/16 13:17:49]

We should rename this to a better name: verticalOffsets

[ostap, 2014/05/22 04:33:19]

Done.

+    if (offsetsSum > containerContentRect.width().toFloat()
+        || offsetsSum + containerContentRect.width().toFloat() > constrainingRect.width()) {
+        if (style()->isLeftToRightDirection()) {
+            constraints.setRightOffset(0);
+            constraints.removeAnchorEdge(ViewportConstraints::AnchorEdgeRight);
+        } else {
+            constraints.setLeftOffset(0);
+            constraints.removeAnchorEdge(ViewportConstraints::AnchorEdgeLeft);

[Julien - ping for review, 2014/05/16 13:17:49]

It would be cleaner if we didn't set the anchor edge in the first place.

The logic doesn't work if we set the right offset with a LTR direction so that
offsetsSum is bigger that the containing block's width. This is an undefined
behavior in the specification but I would have liked to see this mentioned.

[ostap, 2014/05/22 04:33:19]

Done
Actually, the over-constrained means that both left and right or top and bottom
edges are not auto (similar to relative positioning). This check was actually
missed from my 1st patch and I fixed this.
When only one edge offset is bigger than containing block is a different case
and existing calculations do it properly similar to mozilla implementation and
as it was discussed on the CSS mailing list here:
http://lists.w3.org/Archives/Public/www-style/2014Mar/0141.html
It seems this case (with single offset bigger than container) is not covered by
any existing layout test, but it is not related to this patch and I would make
it separately.

+        }
+    }
+
     if (!style()->top().isAuto()) {
         constraints.setTopOffset(floatValueForLength(style()->top(), constrainingRect.height()));
         constraints.addAnchorEdge(ViewportConstraints::AnchorEdgeTop);
     }
 
     if (!style()->bottom().isAuto()) {
-        constraints.setBottomOffset(floatValueForLength(style()->bottom(), constrainingRect.height() ));
+        constraints.setBottomOffset(floatValueForLength(style()->bottom(), constrainingRect.height()));
         constraints.addAnchorEdge(ViewportConstraints::AnchorEdgeBottom);
     }
+
+    offsetsSum = constraints.topOffset() + constraints.bottomOffset();
+    if (offsetsSum > containerContentRect.height().toFloat()
+        || offsetsSum + containerContentRect.height().toFloat() > constrainingRect.height()) {
+        constraints.setBottomOffset(0);
+        constraints.removeAnchorEdge(ViewportConstraints::AnchorEdgeBottom);
+    }

[Julien - ping for review, 2014/05/16 13:17:49]

Shouldn't you check if our writing mode is not bottom-to-top? This is similar to
what you did above for RTL direction.

[ostap, 2014/05/22 04:33:19]

The over-constrained behavior is done similar to position:relative. If we change
it here then, I think, relative positioning should be also changed and spec.
updated. But I'll ask on mozilla bug report which has related discussion:
https://bugzilla.mozilla.org/show_bug.cgi?id=979602

 }
 
 LayoutSize RenderBoxModelObject::stickyPositionOffset() const
 {
     FloatRect constrainingRect;
 
     ASSERT(hasLayer());
     RenderLayer* enclosingClippingLayer = layer()->enclosingOverflowClipLayer(ExcludeSelf);
     if (enclosingClippingLayer) {
         RenderBox* enclosingClippingBox = toRenderBox(enclosingClippingLayer->renderer());
@@ skipping 2473 matching lines @@
     ASSERT(!beforeChild || toBoxModelObject == beforeChild->parent());
     for (RenderObject* child = startChild; child && child != endChild; ) {
         // Save our next sibling as moveChildTo will clear it.
         RenderObject* nextSibling = child->nextSibling();
         moveChildTo(toBoxModelObject, child, beforeChild, fullRemoveInsert);
         child = nextSibling;
     }
 }
 
 } // namespace WebCore