Shorten the generated file name to be less than MAX_PATH (on Windows).

Shorten the generated file name to be less than MAX_PATH (on Windows).

BUG=24591
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28845

[tony, 2009-10-12 23:10:24]

http://codereview.chromium.org/267063/diff/1/2
File chrome/browser/views/tab_contents/tab_contents_view_win.cc (right):

http://codereview.chromium.org/267063/diff/1/2#newcode158
Line 158: fn = fn.substr(fn.size() + drop_data.file_extension.size() +
I see, so this gets the last MAX_PATH characters of the filename?  How about we
get the first MAX_PATH instead? I.e., substr(0, MAX_PATH -
drop_data.file_extension.size() - 1)?

[kuchhal, 2009-10-12 23:15:25]

Sure, that also saves one line. Changed.

[tony, 2009-10-12 23:17:24]

LGTM.  Just to be sure, should it be -1 or -2?  I don't know if you need space
for the NULL terminator or not (I think you need space for the dot tho').

[kuchhal, 2009-10-12 23:24:05]

Yes looks like -2: http://msdn.microsoft.com/en-us/library/aa365247(VS.85).aspx

I was only taking '.' into account. Will change and submit.

Thanks for the review.