Avoid pathological layout on nested percent height tables

third_party/WebKit/Source/core/layout/LayoutTable.cpp

Index: third_party/WebKit/Source/core/layout/LayoutTable.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.cpp b/third_party/WebKit/Source/core/layout/LayoutTable.cpp
index b0a6337f490370f973cdadea505b036af51ef7b8..7ce65dbd0cdcd933af34cbc617af4a3feacedb68 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTable.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTable.cpp
@@ -451,12 +451,13 @@ void LayoutTable::layoutSection(LayoutTableSection& section,
     layouter.setChildNeedsLayout(&section);
   if (!section.needsLayout())
     markChildForPaginationRelayoutIfNeeded(section, layouter);
+  bool neededLayout = section.needsLayout();

[mstensho (USE GERRIT), 2017/02/06 21:11:07]

Might as well do:

if (section.needsLayout()) {
  section.layout();
  section.setLogicalHeight(LayoutUnit(section.calcRowLogicalHeight()));
}

[rhogan, 2017/02/06 21:21:08]

section.layout() is private, should I just make it public?

[mstensho (USE GERRIT), 2017/02/06 21:25:27]

Oh. Yes. This is exactly why it's problematic to override a public method as
private. :)

   section.layoutIfNeeded();
-  int sectionLogicalHeight = section.calcRowLogicalHeight();
-  section.setLogicalHeight(LayoutUnit(sectionLogicalHeight));
+  if (neededLayout)
+    section.setLogicalHeight(LayoutUnit(section.calcRowLogicalHeight()));
   if (view()->layoutState()->isPaginated())
     updateFragmentationInfoForChild(section);
-  setLogicalHeight(logicalHeight() + sectionLogicalHeight);
+  setLogicalHeight(logicalHeight() + section.logicalHeight());
 }
 
 LayoutUnit LayoutTable::logicalHeightFromStyle() const {