Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1735)

Unified Diff: Source/core/rendering/RenderMenuList.cpp

Issue 267053002: ASSERT on renderer lifecycle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderMenuList.cpp
diff --git a/Source/core/rendering/RenderMenuList.cpp b/Source/core/rendering/RenderMenuList.cpp
index b86a69822f4140a770791bccb02319ad13de4f68..2114e740f32abb429baad7cdbc63d48bb0ad22da 100644
--- a/Source/core/rendering/RenderMenuList.cpp
+++ b/Source/core/rendering/RenderMenuList.cpp
@@ -235,6 +235,9 @@ void RenderMenuList::setText(const String& s)
{
if (s.isEmpty()) {
if (!m_buttonText || !m_buttonText->isBR()) {
+ // FIXME: We should not modify the structure of the render tree outside of
+ // recalc style. crbug.com/370462
+ DeprecatedDisableModifyRenderTreeStructureAsserts disabler;
if (m_buttonText)
m_buttonText->destroy();
m_buttonText = new RenderBR(&document());
@@ -245,6 +248,9 @@ void RenderMenuList::setText(const String& s)
if (m_buttonText && !m_buttonText->isBR())
m_buttonText->setText(s.impl(), true);
else {
+ // FIXME: We should not modify the structure of the render tree outside of
+ // recalc style. crbug.com/370462
+ DeprecatedDisableModifyRenderTreeStructureAsserts disabler;
if (m_buttonText)
m_buttonText->destroy();
m_buttonText = new RenderText(&document(), s.impl());

Powered by Google App Engine
This is Rietveld 408576698