Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: Source/core/rendering/RenderFullScreen.cpp

Issue 267053002: ASSERT on renderer lifecycle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderFullScreen.cpp
diff --git a/Source/core/rendering/RenderFullScreen.cpp b/Source/core/rendering/RenderFullScreen.cpp
index bca1d5b9d1cb4bf92d9e00c77339391b43297c36..9e27b51e7a0024d4c527ba164a8a7dbb940d72bf 100644
--- a/Source/core/rendering/RenderFullScreen.cpp
+++ b/Source/core/rendering/RenderFullScreen.cpp
@@ -110,6 +110,10 @@ static PassRefPtr<RenderStyle> createFullScreenStyle()
RenderObject* RenderFullScreen::wrapRenderer(RenderObject* object, RenderObject* parent, Document* document)
{
+ // FIXME: We should not modify the structure of the render tree outside of
+ // recalc style. crbug.com/370459
+ DeprecatedDisableModifyRenderTreeStructureAsserts disabler;
+
RenderFullScreen* fullscreenRenderer = RenderFullScreen::createAnonymous(document);
fullscreenRenderer->setStyle(createFullScreenStyle());
if (parent && !parent->isChildAllowed(fullscreenRenderer, fullscreenRenderer->style())) {
@@ -146,6 +150,10 @@ RenderObject* RenderFullScreen::wrapRenderer(RenderObject* object, RenderObject*
void RenderFullScreen::unwrapRenderer()
{
+ // FIXME: We should not modify the structure of the render tree outside of
+ // recalc style. crbug.com/370459
+ DeprecatedDisableModifyRenderTreeStructureAsserts disabler;
+
if (parent()) {
RenderObject* child;
while ((child = firstChild())) {

Powered by Google App Engine
This is Rietveld 408576698