Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Side by Side Diff: Source/core/dom/Node.cpp

Issue 267053002: ASSERT on renderer lifecycle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/DocumentLifecycle.h ('k') | Source/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 977 matching lines...) Expand 10 before | Expand all | Expand 10 after
988 static Node* detachingNode; 988 static Node* detachingNode;
989 989
990 bool Node::inDetach() const 990 bool Node::inDetach() const
991 { 991 {
992 return detachingNode == this; 992 return detachingNode == this;
993 } 993 }
994 #endif 994 #endif
995 995
996 void Node::detach(const AttachContext& context) 996 void Node::detach(const AttachContext& context)
997 { 997 {
998 DeprecatedDisableModifyRenderTreeStructureAsserts disabler;
999
998 #ifndef NDEBUG 1000 #ifndef NDEBUG
999 ASSERT(!detachingNode); 1001 ASSERT(!detachingNode);
1000 detachingNode = this; 1002 detachingNode = this;
1001 #endif 1003 #endif
1002 1004
1003 if (renderer()) 1005 if (renderer())
1004 renderer()->destroyAndCleanupAnonymousWrappers(); 1006 renderer()->destroyAndCleanupAnonymousWrappers();
1005 setRenderer(0); 1007 setRenderer(0);
1006 1008
1007 // Do not remove the element's hovered and active status 1009 // Do not remove the element's hovered and active status
(...skipping 1581 matching lines...) Expand 10 before | Expand all | Expand 10 after
2589 node->showTreeForThis(); 2591 node->showTreeForThis();
2590 } 2592 }
2591 2593
2592 void showNodePath(const WebCore::Node* node) 2594 void showNodePath(const WebCore::Node* node)
2593 { 2595 {
2594 if (node) 2596 if (node)
2595 node->showNodePathForThis(); 2597 node->showNodePathForThis();
2596 } 2598 }
2597 2599
2598 #endif 2600 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/DocumentLifecycle.h ('k') | Source/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698