Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: chrome/browser/resources/md_bookmarks/toolbar.js

Issue 2670473002: [MD Bookmarks] Implement adding folders and bookmarks from toolbar menu. (Closed)
Patch Set: Fix store to insert node instead of push and update tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/toolbar.js
diff --git a/chrome/browser/resources/md_bookmarks/toolbar.js b/chrome/browser/resources/md_bookmarks/toolbar.js
index 53f002b1be97266b99a0c2b896313ee45b403922..6bc6e15b10c1d8b92ea06adf5ab8dea82e670c36 100644
--- a/chrome/browser/resources/md_bookmarks/toolbar.js
+++ b/chrome/browser/resources/md_bookmarks/toolbar.js
@@ -10,6 +10,8 @@ Polymer({
type: String,
observer: 'onSearchTermChanged_',
},
+
+ createdNode: Object,
},
/** @return {CrToolbarSearchFieldElement} */
@@ -39,6 +41,14 @@ Polymer({
/** @private */
onAddBookmarkTap_: function() {
+ this.createdNode = {isFolder: false};
+ this.$.addBookmark.showModal();
+ this.closeDropdownMenu_();
+ },
+
+ onAddFolderTap_: function() {
+ this.createdNode = {isFolder: true};
+ this.$.addBookmark.showModal();
this.closeDropdownMenu_();
},
@@ -58,6 +68,25 @@ Polymer({
menu.close();
},
+ /** @private */
+ onSaveAddTap_: function() {
+ delete this.createdNode['isFolder'];
+ this.fire('node-added', this.createdNode);
+ this.$.addBookmark.close();
+ },
+
+ /** @private */
+ onCancelAddTap_: function() {
+ this.$.addBookmark.close();
+ },
+
+ /** @private */
+ getModalTitle_: function() {
+ var title =
+ this.createdNode.isFolder ? 'addFolderTitle' : 'addBookmarkTitle';
+ return loadTimeData.getString(title);
+ },
+
/**
* @param {Event} e
* @private

Powered by Google App Engine
This is Rietveld 408576698