[MD Bookmarks] Implement adding folders and bookmarks from toolbar menu.

chrome/browser/resources/md_bookmarks/store.js

Index: chrome/browser/resources/md_bookmarks/store.js
diff --git a/chrome/browser/resources/md_bookmarks/store.js b/chrome/browser/resources/md_bookmarks/store.js
index 8f0ef849e334c115d6178bff4e4628950a34fcd8..34d3aa1d743d20d8de4d48c9f9273e863c1adc09 100644
--- a/chrome/browser/resources/md_bookmarks/store.js
+++ b/chrome/browser/resources/md_bookmarks/store.js
@@ -53,6 +53,7 @@ var BookmarksStore = Polymer({
   /** @override */
   attached: function() {
     this.documentListeners_ = {
+      'add-node-saved': this.onAddNodeSaved_.bind(this),
       'folder-open-changed': this.onFolderOpenChanged_.bind(this),
       'search-term-changed': this.onSearchTermChanged_.bind(this),
       'select-item': this.onItemSelected_.bind(this),
@@ -79,6 +80,7 @@ var BookmarksStore = Polymer({
     // Attach bookmarks API listeners.
     chrome.bookmarks.onRemoved.addListener(this.onBookmarkRemoved_.bind(this));
     chrome.bookmarks.onChanged.addListener(this.onBookmarkChanged_.bind(this));
+    chrome.bookmarks.onCreated.addListener(this.onBookmarkCreated_.bind(this));
   },
 
   //////////////////////////////////////////////////////////////////////////////
@@ -326,6 +328,21 @@ var BookmarksStore = Polymer({
       this.updateSearchDisplay_();
   },
 
+  /**
+   * Called when after a node is created.
+   * @param {string} id The id of the newly added bookmark node.
+   * @param {!BookmarkTreeNode} bookmarkNode
+   */
+  onBookmarkCreated_: function(id, bookmarkNode) {
+    var parent = this.idToNodeMap_[bookmarkNode.parentId || null];

[angelayang, 2017/02/08 07:34:03]

Closure complains that bookmarkNode.parentId can be undefined whilst the
idToNodeMap expects ?string. I'm unsure of what should be done for this.

[jiaxi, 2017/02/09 01:13:09]

I used /** @type {?string} */ in onSelectedFolderChanged. If you come across any
better options can you change the code there as well?

[angelayang, 2017/02/09 03:12:24]

I'll to do the same for consistency sake for now and then see.

+    this.push(parent.path + '.children', bookmarkNode);

[jiaxi, 2017/02/09 01:13:09]

According to my understanding, this adds the new BookmarkTreeNode at the end of
the parent node. If you create an item using the bar the new node will actually
gets 'inserted' into the children.
We might want to check if the BookmarkTreeNode in the callback has an index in
it or not. If it does and there's some function similar to 'insert' in Polymer
we can do that, otherwise we have to getSubTree instead. (Do we have enough time
for finishing this cl?)

[jiaxi, 2017/02/09 01:20:24]

Take a second thought, Polymer's splice could probably insert elements into the
specific index of the array. Make sure all the indexes are correct after you
insert the new element. (Check out how it's done in onBookmarkRemoved_)

This listener handles create event very well from the toolbar. But since we are
only going to use this listener for all onCreate events I think it would be
better to write a listener that works for all cases.

[angelayang, 2017/02/09 03:12:24]

I think what you suggested is good, thanks 

+    BookmarksStore.generatePaths(parent, parent.children.length - 1);
+    BookmarksStore.initNodes(bookmarkNode, this.idToNodeMap_);
+
+    if (this.searchTerm)
+      this.updateSearchDisplay_();
+  },
+
   //////////////////////////////////////////////////////////////////////////////
   // bookmarks-store, bookmarks app event listeners:
 
@@ -375,6 +392,18 @@ var BookmarksStore = Polymer({
   },
 
   /**
+   * Appends a node to the children the selected folder.
+   * @param {CustomEvent} e
+   * @private
+   */
+  onAddNodeSaved_: function(e) {
+    var info = /** @type {!Object} */ (e.detail);
+    info.parentId = this.selectedId;
+    // TODO (angelayang): handle invalid urls.
+    chrome.bookmarks.create(info);
+  },
+
+  /**
    * Selects items according to keyboard behaviours.
    * @param {CustomEvent} e
    * @private
@@ -426,6 +455,9 @@ BookmarksStore.initNodes = function(bookmarkNode, idToNodeMap) {
 
   bookmarkNode.isSelectedFolder = false;
   bookmarkNode.isOpen = true;
+  if (!bookmarkNode.children)
+    bookmarkNode.children = [];
+
   for (var i = 0; i < bookmarkNode.children.length; i++)
     BookmarksStore.initNodes(bookmarkNode.children[i], idToNodeMap);
 };