Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: webkit/tools/layout_tests/flakiness_dashboard.html

Issue 267044: Fix double page generation bug. Now that we use onhashchange,... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/tools/layout_tests/dashboards/dashboard_base.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML> 1 <!DOCTYPE HTML>
2 <html> 2 <html>
3 3
4 <head> 4 <head>
5 <title>Webkit Layout Test History</title> 5 <title>Webkit Layout Test History</title>
6 <style> 6 <style>
7 body { 7 body {
8 font-family: arial; 8 font-family: arial;
9 font-size: 13px; 9 font-size: 13px;
10 } 10 }
(...skipping 1790 matching lines...) Expand 10 before | Expand all | Expand 10 after
1801 showExpectations: 1, 1801 showExpectations: 1,
1802 showLargeExpectations: 1, 1802 showLargeExpectations: 1,
1803 legacyExpectationsSemantics: 1 1803 legacyExpectationsSemantics: 1
1804 }; 1804 };
1805 1805
1806 /** 1806 /**
1807 * Sets the page state and regenerates the page. Takes varargs of key, value 1807 * Sets the page state and regenerates the page. Takes varargs of key, value
1808 * pairs. 1808 * pairs.
1809 */ 1809 */
1810 function setState(var_args) { 1810 function setState(var_args) {
1811 var shouldRegeneratePage = true;
1812 for (var i = 0; i < arguments.length; i += 2) { 1811 for (var i = 0; i < arguments.length; i += 2) {
1813 var key = arguments[i]; 1812 var key = arguments[i];
1814 1813
1815 if (!(key in VALID_KEYS_FOR_INDIVIDUAL_TESTS)) { 1814 if (!(key in VALID_KEYS_FOR_INDIVIDUAL_TESTS)) {
1816 delete currentState.tests; 1815 delete currentState.tests;
1817 } 1816 }
1818 1817
1819 if (key == 'maxResults') { 1818 if (key == 'maxResults') {
1820 // Processing the test results JSON makes assumptions about the number 1819 // Processing the test results JSON makes assumptions about the number
1821 // of results to show. This makes changing the number of maxResults slow 1820 // of results to show. This makes changing the number of maxResults slow
1822 // but is considerably easier than refactoring all the other code. 1821 // but is considerably easier than refactoring all the other code.
1823 clearProcessedTestState(); 1822 clearProcessedTestState();
1824 } 1823 }
1825 } 1824 }
1826 1825
1827 // Set all the custom state for this dashboard before calling 1826 // Set all the custom state for this dashboard before calling
1828 // setQueryParameter since setQueryParameter updates the location bar. 1827 // setQueryParameter since setQueryParameter updates the location bar.
1829 setQueryParameter.apply(null, arguments); 1828 setQueryParameter.apply(null, arguments);
1830
1831 if (shouldRegeneratePage)
1832 handleLocationChange();
1833 } 1829 }
1834 1830
1835 function hideLegend() { 1831 function hideLegend() {
1836 var legend = $('legend'); 1832 var legend = $('legend');
1837 if (legend) 1833 if (legend)
1838 legend.parentNode.removeChild(legend); 1834 legend.parentNode.removeChild(legend);
1839 } 1835 }
1840 1836
1841 var fallbacksMap = {}; 1837 var fallbacksMap = {};
1842 fallbacksMap['WIN-VISTA'] = ['chromium-win-vista', 'chromium-win', 1838 fallbacksMap['WIN-VISTA'] = ['chromium-win-vista', 'chromium-win',
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
1893 hideLegend(); 1889 hideLegend();
1894 hidePopup(); 1890 hidePopup();
1895 } 1891 }
1896 }, false); 1892 }, false);
1897 1893
1898 </script> 1894 </script>
1899 </head> 1895 </head>
1900 1896
1901 <body></body> 1897 <body></body>
1902 </html> 1898 </html>
OLDNEW
« no previous file with comments | « webkit/tools/layout_tests/dashboards/dashboard_base.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698