Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h

Issue 2670433002: Makes descriptors hold nullptr for properties not implemented in API. (Closed)
Patch Set: Neatened up code Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h
diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h
index 938a6e0e977603950a0aadbb1591851e1e270c07..66b49c1d847ce8648f210b6f4cb9f3478f68e1eb 100644
--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h
+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h
@@ -26,13 +26,8 @@ class CSSParserTokenRange;
//
// To add new functions to this API:
// - Add the function to the struct below.
-// - Add the function to CSSPropertyAPIFiles.h.tmpl template file, surrounded
-// with an {% if "methodName" in implementedMethods %} check.
-// - Add the function name to the valid_methods array in
-// make_css_property_apis.py.
-// - Add function to the initializer list in the cssPropertyDescriptors array
-// in CSSPropertyDescriptor.cpp.tmpl, and add a nullptr to the invalid
-// CSSPropertyDescriptor.
+// - Add the function name to the valid_values field for api_methods in
+// CSSProperties.json5.
class CSSPropertyAPI {
STATIC_ONLY(CSSPropertyAPI);

Powered by Google App Engine
This is Rietveld 408576698