Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2670433002: Makes descriptors hold nullptr for properties not implemented in API. (Closed)
Patch Set: removed space Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl ('K') | « third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl ('k') | third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h » ('j') | third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
index 0327c7be2dab5ce7ccdc74d8c65e9cf1c8681194..86a13bf9c5b142ced4fa26d78aaebe9fe6fb64f9 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
@@ -2043,7 +2043,7 @@ const CSSValue* CSSPropertyParser::parseSingleValue(
// statement.
const CSSPropertyDescriptor& cssPropertyDesc =
CSSPropertyDescriptor::get(property);
- if (cssPropertyDesc.temporaryCanReadValue)
+ if (cssPropertyDesc.parseSingleValue)
sashab 2017/02/01 17:50:20 omg awesome
aazzam 2017/02/01 22:33:16 :D
return cssPropertyDesc.parseSingleValue(m_range, m_context);
switch (property) {
« third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl ('K') | « third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl ('k') | third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h » ('j') | third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698