Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Side by Side Diff: third_party/WebKit/Source/build/scripts/make_css_property_apis.py

Issue 2670433002: Makes descriptors hold nullptr for properties not implemented in API. (Closed)
Patch Set: Neatened up code Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2016 The Chromium Authors. All rights reserved. 2 # Copyright 2016 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import sys 6 import sys
7 7
8 import json5_generator 8 import json5_generator
9 import template_expander 9 import template_expander
10 import make_style_builder 10 import make_style_builder
(...skipping 13 matching lines...) Expand all
24 24
25 class CSSPropertyAPIWriter(make_style_builder.StyleBuilderWriter): 25 class CSSPropertyAPIWriter(make_style_builder.StyleBuilderWriter):
26 def __init__(self, json5_file_path): 26 def __init__(self, json5_file_path):
27 super(CSSPropertyAPIWriter, self).__init__(json5_file_path) 27 super(CSSPropertyAPIWriter, self).__init__(json5_file_path)
28 self._outputs = { 28 self._outputs = {
29 'CSSPropertyDescriptor.cpp': self.generate_property_descriptor_cpp, 29 'CSSPropertyDescriptor.cpp': self.generate_property_descriptor_cpp,
30 } 30 }
31 31
32 # Temporary map of API classname to list of propertyIDs that the API cla ss is for. 32 # Temporary map of API classname to list of propertyIDs that the API cla ss is for.
33 properties_for_class = defaultdict(list) 33 properties_for_class = defaultdict(list)
34 # Temporary map of API classname to set of method names this API class i mplements
35 api_methods_for_class = defaultdict(set)
34 for property in self._properties.values(): 36 for property in self._properties.values():
35 if property['api_class'] is None: 37 if property['api_class'] is None:
36 continue 38 continue
37 classname = get_classname(property) 39 classname = get_classname(property)
40 api_methods_for_class[classname] = property['api_methods']
38 properties_for_class[classname].append(property['property_id']) 41 properties_for_class[classname].append(property['property_id'])
39 self._outputs[classname + '.h'] = self.generate_property_api_h_build er(classname, property['api_methods']) 42 self._outputs[classname + '.h'] = self.generate_property_api_h_build er(classname, property['api_methods'])
40 43
41 # Stores a list of classes with elements (index, classname, [propertyIDs , ..]). 44 # Stores a list of classes with elements (index, classname, [propertyIDs , ..], [api_methods, ...]).
42 self._api_classes = [] 45 self._api_classes = []
43 46
44 ApiClass = namedtuple('ApiClass', ('index', 'classname', 'property_ids') ) 47 ApiClass = namedtuple('ApiClass', ('index', 'classname', 'property_ids', 'api_methods'))
45 for i, classname in enumerate(properties_for_class.keys()): 48 for i, classname in enumerate(properties_for_class.keys()):
46 self._api_classes.append(ApiClass( 49 self._api_classes.append(ApiClass(
47 index=i + 1, 50 index=i + 1,
48 classname=classname, 51 classname=classname,
49 property_ids=properties_for_class[classname] 52 property_ids=properties_for_class[classname],
53 api_methods=api_methods_for_class[classname],
50 )) 54 ))
51 55
52 @template_expander.use_jinja('CSSPropertyDescriptor.cpp.tmpl') 56 @template_expander.use_jinja('CSSPropertyDescriptor.cpp.tmpl')
53 def generate_property_descriptor_cpp(self): 57 def generate_property_descriptor_cpp(self):
54 return { 58 return {
55 'api_classes': self._api_classes, 59 'api_classes': self._api_classes,
60 'api_methods': self.json5_file.parameters['api_methods']['valid_valu es'],
56 } 61 }
57 62
58 # Provides a function object given the classname of the property. 63 # Provides a function object given the classname of the property.
59 # This returned function generates a .h file for the specified property.
60 def generate_property_api_h_builder(self, api_classname, api_methods): 64 def generate_property_api_h_builder(self, api_classname, api_methods):
61 @template_expander.use_jinja('CSSPropertyAPIFiles.h.tmpl') 65 @template_expander.use_jinja('CSSPropertyAPIFiles.h.tmpl')
62 def generate_property_api_h(): 66 def generate_property_api_h():
63 return { 67 return {
64 'api_classname': api_classname, 68 'api_classname': api_classname,
65 'api_methods': api_methods, 69 'api_methods': api_methods,
66 } 70 }
67 return generate_property_api_h 71 return generate_property_api_h
68 72
69 if __name__ == '__main__': 73 if __name__ == '__main__':
70 json5_generator.Maker(CSSPropertyAPIWriter).main() 74 json5_generator.Maker(CSSPropertyAPIWriter).main()
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698