Makes descriptors hold nullptr for properties not implemented in API.

third_party/WebKit/Source/build/scripts/make_css_property_apis.py

 #!/usr/bin/env python
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import sys
 
 import json5_generator
 import template_expander
 import make_style_builder
@@ skipping 13 matching lines @@
 
 class CSSPropertyAPIWriter(make_style_builder.StyleBuilderWriter):
     def __init__(self, json5_file_path):
         super(CSSPropertyAPIWriter, self).__init__(json5_file_path)
         self._outputs = {
             'CSSPropertyDescriptor.cpp': self.generate_property_descriptor_cpp,
         }
 
         # Temporary map of API classname to list of propertyIDs that the API class is for.
         properties_for_class = defaultdict(list)
+        api_methods_for_class = defaultdict(set)
         for property in self._properties.values():
             if property['api_class'] is None:
                 continue
             classname = get_classname(property)
+            api_methods_for_class[classname].update(property['api_methods'])
             properties_for_class[classname].append(property['property_id'])
             self._outputs[classname + '.h'] = self.generate_property_api_h_builder(classname, property['api_methods'])
 
-        # Stores a list of classes with elements (index, classname, [propertyIDs, ..]).
+        # Stores a list of classes with elements (index, classname, [propertyIDs, ..], api_methods).
         self._api_classes = []
 
-        ApiClass = namedtuple('ApiClass', ('index', 'classname', 'property_ids'))
+        ApiClass = namedtuple('ApiClass', ('index', 'classname', 'property_ids', 'api_methods'))
         for i, classname in enumerate(properties_for_class.keys()):
             self._api_classes.append(ApiClass(
                 index=i + 1,
                 classname=classname,
-                property_ids=properties_for_class[classname]
+                property_ids=properties_for_class[classname],
+                api_methods=api_methods_for_class[classname],
             ))
 
     @template_expander.use_jinja('CSSPropertyDescriptor.cpp.tmpl')
     def generate_property_descriptor_cpp(self):
         return {
             'api_classes': self._api_classes,
+            'valid_api_methods': self.json5_file.parameters["api_methods"]["valid_values"],

[ktyliu, 2017/02/01 00:32:29]

would simply "api_methods" be a better name rather than "valid_api_methods"?

[aazzam, 2017/02/01 06:02:28]

renamed :)

[aazzam, 2017/02/01 06:02:28]

renamed :)

         }
 
     # Provides a function object given the classname of the property.
     # This returned function generates a .h file for the specified property.
     def generate_property_api_h_builder(self, api_classname, api_methods):
         @template_expander.use_jinja('CSSPropertyAPIFiles.h.tmpl')
         def generate_property_api_h():
             return {
                 'api_classname': api_classname,
                 'api_methods': api_methods,
             }
         return generate_property_api_h
 
 if __name__ == '__main__':
     json5_generator.Maker(CSSPropertyAPIWriter).main()