Add an interface to report the amount of data after a chunked encoding....

Add an interface to report the amount of data after a chunked encoding. This will be needed for pipelining. Separated out of http://codereview.chromium.org/249031.

BUG=13289
TEST=existing and added unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28833

[wtc, 2009-10-09 22:47:36]

LGTM.

http://codereview.chromium.org/267042/diff/1/2
File net/http/http_chunked_decoder.h (right):

http://codereview.chromium.org/267042/diff/1/2#newcode80
Line 80: int bytes_after_eof() const { return reached_eof_ ? bytes_after_eof_ :
0; }
It seems that this method can just return bytes_after_eof_,
without testing reached_eof_.

http://codereview.chromium.org/267042/diff/1/3
File net/http/http_chunked_decoder_unittest.cc (right):

http://codereview.chromium.org/267042/diff/1/3#newcode31
Line 31: EXPECT_TRUE(result == expected_output);
Could you change these two lines to use EXPECT_EQ?

http://codereview.chromium.org/267042/diff/1/3#newcode303
Line 303: TEST(HttpChunkedDecoderTest, MultipleExtraDatas) {
Nit: Isn't "Data" already plural? :-)

[vandebo (ex-Chrome), 2009-10-12 16:37:32]

Will commit this when tree opens...

http://codereview.chromium.org/267042/diff/1/2
File net/http/http_chunked_decoder.h (right):

http://codereview.chromium.org/267042/diff/1/2#newcode80
Line 80: int bytes_after_eof() const { return reached_eof_ ? bytes_after_eof_ :
0; }
On 2009/10/09 22:47:37, wtc wrote:
> It seems that this method can just return bytes_after_eof_,
> without testing reached_eof_.

Done.

http://codereview.chromium.org/267042/diff/1/3
File net/http/http_chunked_decoder_unittest.cc (right):

http://codereview.chromium.org/267042/diff/1/3#newcode31
Line 31: EXPECT_TRUE(result == expected_output);
On 2009/10/09 22:47:37, wtc wrote:
> Could you change these two lines to use EXPECT_EQ?

Done.

http://codereview.chromium.org/267042/diff/1/3#newcode303
Line 303: TEST(HttpChunkedDecoderTest, MultipleExtraDatas) {
On 2009/10/09 22:47:37, wtc wrote:
> Nit: Isn't "Data" already plural? :-)

Done.

[wtc, 2009-10-12 18:48:19]

LGTM.

http://codereview.chromium.org/267042/diff/4001/4003
File net/http/http_chunked_decoder_unittest.cc (right):

http://codereview.chromium.org/267042/diff/4001/4003#newcode31
Line 31: EXPECT_EQ(result, expected_output);
Another nit: in these EXPECT_XX macros, the expected value
should be listed first.  This only matters in the printout
when the EXPECT_EQ macros fail.  You will get a more meaningful
printout if you list the parameters in the right order
(expected, actual).