third_party/WebKit/Source/core/layout/Grid.cpp - Issue 2670363003: [css-grid] Clamp the number of auto repeat tracks in all cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/Grid.cpp

Issue 2670363003: [css-grid] Clamp the number of auto repeat tracks in all cases (Closed)

Patch Set: New version matching the specs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/Grid.cpp

diff --git a/third_party/WebKit/Source/core/layout/Grid.cpp b/third_party/WebKit/Source/core/layout/Grid.cpp

index aa65a6c0aeee8eca2f49b03c132e8d9048a55987..580e1a108e3146eb3b306f06f3ad0f49d6fe8952 100644

--- a/third_party/WebKit/Source/core/layout/Grid.cpp

+++ b/third_party/WebKit/Source/core/layout/Grid.cpp

@@ -81,6 +81,10 @@ bool Grid::hasAnyGridItemPaintOrder() const {

void Grid::setAutoRepeatTracks(size_t autoRepeatRows,

size_t autoRepeatColumns) {

+ DCHECK_GE(static_cast<unsigned>(kGridMaxTracks),

+ numTracks(ForRows) + autoRepeatRows);

+ DCHECK_GE(static_cast<unsigned>(kGridMaxTracks),

+ numTracks(ForColumns) + autoRepeatColumns);

m_autoRepeatRows = autoRepeatRows;

m_autoRepeatColumns = autoRepeatColumns;

}