Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: tools/perf/benchmarks/system_health.py

Issue 2670363002: [system-health] Re-enable memory_mobile.reference on Nexus 5X. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/system_health.py
diff --git a/tools/perf/benchmarks/system_health.py b/tools/perf/benchmarks/system_health.py
index 2b013a55d969de3a2e8ba89bada91111a547542a..17b44a5a48773698815291c79afee5ce7d1101b1 100644
--- a/tools/perf/benchmarks/system_health.py
+++ b/tools/perf/benchmarks/system_health.py
@@ -72,11 +72,6 @@ class MobileCommonSystemHealth(_CommonSystemHealthBenchmark):
@classmethod
def ShouldDisable(cls, possible_browser):
- # http://crbug.com/612144
- if (possible_browser.browser_type == 'reference' and
- possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
- return True
-
return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
@@ -137,11 +132,6 @@ class MobileMemorySystemHealth(_MemorySystemHealthBenchmark):
@classmethod
def ShouldDisable(cls, possible_browser):
nednguyen 2017/02/03 16:51:01 Can you update this benchmark class to just use "@
kraynov 2017/02/03 17:03:12 Done.
- # http://crbug.com/612144
- if (possible_browser.browser_type == 'reference' and
- possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
- return True
-
return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
def SetExtraBrowserOptions(self, options):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698