third_party/WebKit/LayoutTests/fast/canvas/canvas-arc-negative-radius.html - Issue 2670353002: Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/canvas/canvas-arc-negative-radius.html

Issue 2670353002: Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. (Closed)

Patch Set: Addressing comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/canvas-arc-connecting-line-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/canvas/canvas-arc-negative-radius-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/canvas/canvas-arc-negative-radius.html

diff --git a/third_party/WebKit/LayoutTests/fast/canvas/canvas-arc-negative-radius.html b/third_party/WebKit/LayoutTests/fast/canvas/canvas-arc-negative-radius.html

index a1810f53b5e1f51acf0fa6be782bf0529d750d0b..8c52cc5b6a6a0ef3d9b3720fc516e7ddc8e6642e 100644

--- a/third_party/WebKit/LayoutTests/fast/canvas/canvas-arc-negative-radius.html

+++ b/third_party/WebKit/LayoutTests/fast/canvas/canvas-arc-negative-radius.html

@@ -1,35 +1,29 @@

-<!DOCTYPE html>

-<html>

-<head>

-<script src="../../resources/js-test.js"></script>

-</head>

-<body>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

-description("Tests CanvasPathMethods arc and arcTo with negative radii.");

+test(function(t) {

+ var canvas = document.createElement("canvas");

+ var ctx = canvas.getContext('2d');

-var canvas = document.createElement("canvas");

-var ctx = canvas.getContext('2d');

+ ctx.arc(10, 10, 5, 0, 1, false);

+ ctx.arc(10, 10, 0, 0, 1, false);

+ assert_throws(null, function() {ctx.arc(10, 10, -5, 0, 1, false);});

-shouldNotThrow("ctx.arc(10, 10, 5, 0, 1, false)");

-shouldNotThrow("ctx.arc(10, 10, 0, 0, 1, false)");

-shouldThrow("ctx.arc(10, 10, -5, 0, 1, false)");

+ ctx.arcTo(10, 10, 20, 20, 5);

+ ctx.arcTo(10, 10, 20, 20, 0);

+ assert_throws(null, function() {ctx.arcTo(10, 10, 20, 20, -5);});

-shouldNotThrow("ctx.arcTo(10, 10, 20, 20, 5)")

-shouldNotThrow("ctx.arcTo(10, 10, 20, 20, 0)")

-shouldThrow("ctx.arcTo(10, 10, 20, 20, -5)")

+ var path = new Path2D();

-var path = new Path2D();

+ path.arc(10, 10, 5, 0, 1, false);

+ path.arc(10, 10, 0, 0, 1, false);

+ assert_throws(null, function() {path.arc(10, 10, -5, 0, 1, false);});

-shouldNotThrow("path.arc(10, 10, 5, 0, 1, false)");

-shouldNotThrow("path.arc(10, 10, 0, 0, 1, false)");

-shouldThrow("path.arc(10, 10, -5, 0, 1, false)");

-shouldNotThrow("path.arcTo(10, 10, 20, 20, 5)")

-shouldNotThrow("path.arcTo(10, 10, 20, 20, 0)")

-shouldThrow("path.arcTo(10, 10, 20, 20, -5)")

+ path.arcTo(10, 10, 20, 20, 5);

+ path.arcTo(10, 10, 20, 20, 0);

+ assert_throws(null, function() {path.arcTo(10, 10, 20, 20, -5);});

+}, 'Tests CanvasPathMethods arc and arcTo with negative radii.');

</script>

-</body>

-</html>