Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4512)

Unified Diff: cc/output/copy_output_request.h

Issue 2670213006: Mojom structs for copy requests / results should map to unique_ptr (Closed)
Patch Set: c Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/ipc/struct_traits_unittest.cc ('k') | cc/output/copy_output_result.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/copy_output_request.h
diff --git a/cc/output/copy_output_request.h b/cc/output/copy_output_request.h
index 2bc0b4d0c7b244f716cf0df8c3afa77ecc3e4dbb..112daa40dcefe08ad0b4c567badf096b378e2778 100644
--- a/cc/output/copy_output_request.h
+++ b/cc/output/copy_output_request.h
@@ -47,8 +47,6 @@ class CC_EXPORT CopyOutputRequest {
const CopyOutputRequest& original_request,
const CopyOutputRequestCallback& result_callback);
- CopyOutputRequest();
-
~CopyOutputRequest();
bool IsEmpty() const { return result_callback_.is_null(); }
@@ -87,8 +85,9 @@ class CC_EXPORT CopyOutputRequest {
private:
friend struct mojo::StructTraits<mojom::CopyOutputRequestDataView,
- CopyOutputRequest>;
+ std::unique_ptr<CopyOutputRequest>>;
+ CopyOutputRequest();
CopyOutputRequest(bool force_bitmap_result,
const CopyOutputRequestCallback& result_callback);
@@ -97,6 +96,8 @@ class CC_EXPORT CopyOutputRequest {
base::Optional<gfx::Rect> area_;
base::Optional<TextureMailbox> texture_mailbox_;
CopyOutputRequestCallback result_callback_;
+
+ DISALLOW_COPY_AND_ASSIGN(CopyOutputRequest);
};
} // namespace cc
« no previous file with comments | « cc/ipc/struct_traits_unittest.cc ('k') | cc/output/copy_output_result.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698