Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: cc/ipc/copy_output_result_struct_traits.cc

Issue 2670213006: Mojom structs for copy requests / results should map to unique_ptr (Closed)
Patch Set: c Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/ipc/copy_output_result_struct_traits.h ('k') | cc/ipc/struct_traits_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/ipc/copy_output_result_struct_traits.h" 5 #include "cc/ipc/copy_output_result_struct_traits.h"
6 6
7 namespace mojo { 7 namespace mojo {
8 8
9 // static 9 // static
10 bool StructTraits<cc::mojom::CopyOutputResultDataView, cc::CopyOutputResult>:: 10 bool StructTraits<cc::mojom::CopyOutputResultDataView,
11 Read(cc::mojom::CopyOutputResultDataView data, cc::CopyOutputResult* out) { 11 std::unique_ptr<cc::CopyOutputResult>>::
12 out->bitmap_ = base::MakeUnique<SkBitmap>(); 12 Read(cc::mojom::CopyOutputResultDataView data,
13 return data.ReadSize(&out->size_) && data.ReadBitmap(out->bitmap_.get()) && 13 std::unique_ptr<cc::CopyOutputResult>* out_p) {
14 data.ReadTextureMailbox(&out->texture_mailbox_); 14 auto result = cc::CopyOutputResult::CreateEmptyResult();
15
16 if (!data.ReadSize(&result->size_))
17 return false;
18
19 result->bitmap_ = base::MakeUnique<SkBitmap>();
20 if (!data.ReadBitmap(result->bitmap_.get()))
21 return false;
22
23 if (!data.ReadTextureMailbox(&result->texture_mailbox_))
24 return false;
25
26 *out_p = std::move(result);
27
28 return true;
15 } 29 }
16 30
17 // static 31 // static
18 const SkBitmap& 32 const SkBitmap& StructTraits<cc::mojom::CopyOutputResultDataView,
19 StructTraits<cc::mojom::CopyOutputResultDataView, cc::CopyOutputResult>::bitmap( 33 std::unique_ptr<cc::CopyOutputResult>>::
20 const cc::CopyOutputResult& result) { 34 bitmap(const std::unique_ptr<cc::CopyOutputResult>& result) {
21 static SkBitmap* null_bitmap = new SkBitmap(); 35 static SkBitmap* null_bitmap = new SkBitmap();
22 if (!result.bitmap_) 36 if (!result->bitmap_)
23 return *null_bitmap; 37 return *null_bitmap;
24 return *result.bitmap_; 38 return *result->bitmap_;
25 } 39 }
26 40
27 } // namespace mojo 41 } // namespace mojo
OLDNEW
« no previous file with comments | « cc/ipc/copy_output_result_struct_traits.h ('k') | cc/ipc/struct_traits_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698