Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp

Issue 2670213005: Hook ANGLE_request_extension up to the passthrough cmd decoder. (Closed)
Patch Set: Address zmo's comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp b/third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp
index dd5047330e1f78625ce29b75a3d7a95f2df2d702..6d024272b66e814464ce57ccf80b00234a9e7826 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp
@@ -102,6 +102,12 @@ bool WebGLDrawBuffers::satisfiesWebGLRequirements(
gpu::gles2::GLES2Interface* gl = webglContext->contextGL();
Extensions3DUtil* extensionsUtil = webglContext->extensionsUtil();
+ if (extensionsUtil->isExtensionRequestable("GL_EXT_draw_buffers")) {
Zhenyao Mo 2017/02/15 23:24:20 This is also true even if the extension is not ena
Geoff Lang 2017/02/16 15:38:45 Removed this method. I agree and prefer to trust
+ // Extension can be enabled but is not yet so we trust that the command
+ // decoder has full support
+ return true;
+ }
+
// This is called after we make sure GL_EXT_draw_buffers is supported.
GLint maxDrawBuffers = 0;
GLint maxColorAttachments = 0;

Powered by Google App Engine
This is Rietveld 408576698