Hook ANGLE_request_extension up to the passthrough cmd decoder.

gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h"
 
 #include "gpu/command_buffer/service/feature_info.h"
 #include "gpu/command_buffer/service/gl_utils.h"
 #include "ui/gl/gl_version_info.h"
 
@@ skipping 58 matching lines @@
   texture_object_map.clear();
 }
 
 GLES2DecoderPassthroughImpl::GLES2DecoderPassthroughImpl(ContextGroup* group)
     : commands_to_process_(0),
       debug_marker_manager_(),
       logger_(&debug_marker_manager_),
       surface_(),
       context_(),
       group_(group),
-      feature_info_(group->feature_info()) {
+      feature_info_(new FeatureInfo) {
   DCHECK(group);
 }
 
 GLES2DecoderPassthroughImpl::~GLES2DecoderPassthroughImpl() {}
 
 GLES2Decoder::Error GLES2DecoderPassthroughImpl::DoCommands(
     unsigned int num_commands,
     const volatile void* buffer,
     int num_entries,
     int* entries_processed) {
@@ skipping 72 matching lines @@
   context_ = context;
   surface_ = surface;
 
   if (!group_->Initialize(this, attrib_helper.context_type,
                           disallowed_features)) {
     group_ = NULL;  // Must not destroy ContextGroup if it is not initialized.
     Destroy(true);
     return false;
   }
 
+  // Each context initializes its own feature info because some extensions may
+  // be enabled dynamically

[Zhenyao Mo, 2017/02/06 22:31:38]

I am wondering if this is necessary - WebGL has no plans to share resources in
the near future, so basically WebGL will be in the one context per group
situation.

[Geoff Lang, 2017/02/07 19:01:15]

I wanted to be sure that the feature info doesn't get out of sync, I don't think
there is currently anything stopping a non-webgl context from calling
glRequestExtensionCHOMRIUM.  I could add an assert in DoRequestExtensionCHOMRIUM
that the context group only has one context or keep it as is, have a preference?

+  DisallowedFeatures adjusted_disallowed_features =
+      AdjustDisallowedFeatures(attrib_helper.context_type, disallowed_features);
+  if (!feature_info_->Initialize(attrib_helper.context_type,
+                                 adjusted_disallowed_features)) {
+    Destroy(true);
+    return false;
+  }
+
   // Check for required extensions
   if (!feature_info_->feature_flags().angle_robust_client_memory ||
-      !feature_info_->feature_flags().chromium_bind_generates_resource) {
-    // TODO(geofflang): Verify that ANGLE_webgl_compatibility is enabled if this
-    // is a WebGL context (depends on crbug.com/671217).
+      !feature_info_->feature_flags().chromium_bind_generates_resource ||
+      feature_info_->feature_flags().angle_webgl_compatibility !=
+          IsWebGLContextType(attrib_helper.context_type) ||
+      !feature_info_->feature_flags().angle_request_extension) {
     Destroy(true);
     return false;
   }
 
   image_manager_.reset(new ImageManager());
 
   bind_generates_resource_ = group_->bind_generates_resource();
 
   resources_ = group_->passthrough_resources();
 
@@ skipping 662 matching lines @@
   }, /* NOLINT */
 
 const GLES2DecoderPassthroughImpl::CommandInfo
     GLES2DecoderPassthroughImpl::command_info[] = {
         GLES2_COMMAND_LIST(GLES2_CMD_OP)};
 
 #undef GLES2_CMD_OP
 
 }  // namespace gles2
 }  // namespace gpu