src/effects/SkLightingImageFilter.cpp - Issue 26702002: force readbuffer clients to use specialized readFoo for flattenables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLightingImageFilter.cpp

Issue 26702002: force readbuffer clients to use specialized readFoo for flattenables (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: plumbed EffectType into readFlattenable() Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkLightingImageFilter.cpp

diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp

index c28b317e225c41bfcd04a338b3b59c789b1831db..9d0255246616d83eeefe9893aa0e57ab0006a58a 100644

--- a/src/effects/SkLightingImageFilter.cpp

+++ b/src/effects/SkLightingImageFilter.cpp

@@ -867,7 +867,7 @@ SkLightingImageFilter::~SkLightingImageFilter() {

SkLightingImageFilter::SkLightingImageFilter(SkFlattenableReadBuffer& buffer)

: INHERITED(buffer)

{

- fLight = buffer.readFlattenableT<SkLight>();

+ fLight = buffer.readLight();

fSurfaceScale = buffer.readScalar();

}