src/core/SkImageFilter.cpp - Issue 26702002: force readbuffer clients to use specialized readFoo for flattenables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkImageFilter.cpp

Issue 26702002: force readbuffer clients to use specialized readFoo for flattenables (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: plumbed EffectType into readFlattenable() Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkImageFilter.cpp

diff --git a/src/core/SkImageFilter.cpp b/src/core/SkImageFilter.cpp

index 3b7de25c93ed1ca5b51b1154493789745878510e..c8c0c4dbf8257000d8eaa9bb07cf788a6730849d 100644

--- a/src/core/SkImageFilter.cpp

+++ b/src/core/SkImageFilter.cpp

@@ -68,7 +68,7 @@ SkImageFilter::SkImageFilter(SkFlattenableReadBuffer& buffer)

: fInputCount(buffer.readInt()), fInputs(new SkImageFilter*[fInputCount]) {

for (int i = 0; i < fInputCount; i++) {

if (buffer.readBool()) {

- fInputs[i] = static_cast<SkImageFilter*>(buffer.readFlattenable());

+ fInputs[i] = buffer.readImageFilter();

} else {

fInputs[i] = NULL;

}