Issue 267013005: Remove cursor_mac.mm, fix GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 267013005: Remove cursor_mac.mm, fix GN build. (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove cursor_mac.mm, fix GN build. cursor_mac.mm is never included on any Mac build because it's removed for all non-aura builds, which includes Mac. This file just seems to be stubs anyway. Also fixes a missing comma in the GN Mac build. R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269543

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -22 lines)			Patch
M	build/config/mac/mac_sdk.gni	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/BUILD.gn	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	ui/base/cursor/cursor_mac.mm	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	ui/base/ui_base.gyp	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/267013005/1

6 years, 7 months ago (2014-05-09 05:42:56 UTC) #4

Message was sent while issue was closed.

Change committed as 269543

Expand Messages | Collapse Messages