[Download Home] Displaying offline page bundle per day

chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
index b6b11e530053aead0e7f0bd20ae373dcae227a65..cf60a4c2f9ffbe365348009aa6530d0aefa88232 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
@@ -5,9 +5,12 @@
 package org.chromium.chrome.browser.download.ui;
 
 import android.content.ComponentName;
+import android.support.v7.widget.RecyclerView;
 import android.support.v7.widget.RecyclerView.ViewHolder;
 import android.text.TextUtils;
+import android.util.Pair;
 import android.view.LayoutInflater;
+import android.view.View;
 import android.view.ViewGroup;
 
 import org.chromium.base.ObserverList;
@@ -204,6 +207,43 @@ public class DownloadHistoryAdapter extends DateDividedAdapter
         return R.layout.date_view;
     }
 
+    private static class OfflineGroupHeaderViewHolder extends RecyclerView.ViewHolder {
+        private OfflineGroupHeaderView mView;
+
+        public OfflineGroupHeaderViewHolder(View view) {
+            super(view);
+            mView = (OfflineGroupHeaderView) view;
+        }
+
+        public OfflineGroupHeaderView getView() {
+            return mView;
+        }
+    }
+
+    @Override
+    public final RecyclerView.ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
+        if (viewType == TYPE_SUBSECTION_HEADER) {
+            return new OfflineGroupHeaderViewHolder(

[Theresa, 2017/02/10 00:55:12]

For consistency with how we create headers,
DateDividedAdapter#onCreateViewHolder() should include something liek this:

if (viewType == TYPE_SUBSECTION_HEADER) {
   return createSubsectionHeader();
}

and this inflate should be moved to an overridden createSubsectionHeader().

[shaktisahu, 2017/02/10 21:30:24]

Good idea! Thanks.

+                    LayoutInflater.from(parent.getContext())
+                            .inflate(R.layout.offline_download_header, parent, false));
+        } else {
+            return super.onCreateViewHolder(parent, viewType);
+        }
+    }
+
+    @Override
+    public final void onBindViewHolder(RecyclerView.ViewHolder holder, int position) {
+        if (holder instanceof OfflineGroupHeaderViewHolder) {
+            Pair<ItemGroup, Integer> pair = getGroupAt(position);
+            DownloadItemGroup group = (DownloadItemGroup) pair.first;
+            OfflineGroupHeaderView offlineHeader =
+                    ((OfflineGroupHeaderViewHolder) holder).getView();
+            offlineHeader.bindGroupAndAdapter(group, this);

[Theresa, 2017/02/10 00:55:12]

The adapter can be set when the OfflineGroupHeaderViewHolder is inflated since
that won't change.

[shaktisahu, 2017/02/10 21:30:24]

Done.

+        } else {
+            super.onBindViewHolder(holder, position);
+        }
+    }
+
     @Override
     public ViewHolder createViewHolder(ViewGroup parent) {
         DownloadItemView v = (DownloadItemView) LayoutInflater.from(parent.getContext()).inflate(
@@ -221,6 +261,26 @@ public class DownloadHistoryAdapter extends DateDividedAdapter
         holder.getItemView().displayItem(mBackendProvider, item);
     }
 
+    public void expandSuggestedPagesHeader(DownloadItemGroup group) {

[gone, 2017/02/10 02:31:44]

1) javadocs for public methods
2) This is basically the same as collapse, with a true instead of a false.  Can
you consolidate the two?

public void setSuggestedPagesHeaderState(DownloadItemGroup group, boolean state)

[shaktisahu, 2017/02/10 21:30:24]

Done. Thanks!

+        group.setIsSuggestedOfflinePagesSectionExpanded(true);
+        computeItemCount();
+        setGroupPositions();
+        notifyDataSetChanged();
+    }
+
+    public void collapseSuggestedPagesHeader(DownloadItemGroup group) {
+        group.setIsSuggestedOfflinePagesSectionExpanded(false);
+        computeItemCount();
+        setGroupPositions();
+        notifyDataSetChanged();
+    }
+
+    @Override
+    protected ItemGroup createGroup(long timeStamp) {
+        ItemGroup group = new DownloadItemGroup(timeStamp);
+        return group;
+    }
+
     /** Called when a new DownloadItem has been created by the native DownloadManager. */
     public void onDownloadItemCreated(DownloadItem item) {
         boolean isOffTheRecord = item.getDownloadInfo().isOffTheRecord();