[Download Home] Displaying offline page bundle per day

chrome/android/java/src/org/chromium/chrome/browser/download/ui/OfflineGroupHeaderView.java

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.download.ui;
+
+import android.content.Context;
+import android.text.format.Formatter;
+import android.util.AttributeSet;
+import android.view.View;
+import android.widget.FrameLayout;
+import android.widget.ImageView;
+import android.widget.TextView;
+
+import org.chromium.chrome.R;
+
+import java.util.Date;
+
+/** A header that presents users the option to view or hide the suggested offline pages. */
+public class OfflineGroupHeaderView extends FrameLayout {
+    private Date mDate;
+    private DownloadHistoryAdapter mAdapter;
+
+    private TextView mPageCountHeader;
+    private TextView mFileSizeView;
+    private ImageView mImageView;
+
+    public OfflineGroupHeaderView(Context context, AttributeSet attrs) {
+        super(context, attrs);
+        setOnClickListener(new View.OnClickListener() {
+            @Override
+            public void onClick(View v) {
+                boolean currentState = mAdapter.isSubsectionExpanded(mDate);

[gone, 2017/02/15 23:58:09]

Instead of negating it twice, just do it once:

boolean newState = !mAdapter.isSubsectionExpanded(mDate);

[shaktisahu, 2017/02/16 06:07:06]

Done.

+                mAdapter.setSubsectionExpanded(mDate, !currentState);
+                updateImageView(!currentState);
+            }
+        });
+    }
+
+    @Override
+    protected void onFinishInflate() {
+        super.onFinishInflate();
+        mPageCountHeader = (TextView) findViewById(R.id.page_count_text);
+        mFileSizeView = (TextView) findViewById(R.id.filesize_view);
+        mImageView = (ImageView) findViewById(R.id.expand_icon);
+    }
+
+    /**
+     * @param adapter The adapter associated with this header.
+     */
+    public void setAdapter(DownloadHistoryAdapter adapter) {
+        mAdapter = adapter;
+    }
+
+    /**
+     *

[gone, 2017/02/15 23:58:09]

Finish this comment.

[shaktisahu, 2017/02/16 06:07:06]

Done.

+     * @param date
+     * @param expanded
+     * @param pageCount
+     * @param fileSize
+     */
+    public void updateView(Date date, boolean expanded, int pageCount, long fileSize) {

[gone, 2017/02/15 23:58:09]

Call this update()?

[shaktisahu, 2017/02/16 06:07:06]

Done.

+        mDate = date;
+        mPageCountHeader.setText(getResources().getString(
+                R.string.download_manager_offline_header_title, pageCount));
+        mFileSizeView.setText(Formatter.formatFileSize(getContext(), fileSize));
+        updateImageView(expanded);
+    }
+
+    private void updateImageView(boolean expanded) {
+        mImageView.setImageResource(expanded ? R.drawable.ic_expanded : R.drawable.ic_collapsed);
+        mImageView.setContentDescription(
+                getResources().getString(expanded ? R.string.accessibility_collapse_offline_pages
+                                                  : R.string.accessibility_expand_offline_pages));
+    }
+}