[Download Home] Displaying offline page bundle per day

chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemGroup.java

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.download.ui;
+
+import org.chromium.chrome.browser.download.ui.DownloadHistoryAdapter.SubsectionHeader;
+import org.chromium.chrome.browser.download.ui.DownloadHistoryItemWrapper.OfflinePageItemWrapper;
+import org.chromium.chrome.browser.widget.DateDividedAdapter;
+import org.chromium.chrome.browser.widget.DateDividedAdapter.TimedItem;
+
+/**
+ * A bucket of downloaded items with the same date. It also holds the suggested offline items which
+ * are shown at the end of the list for that date.
+ */
+public class DownloadItemGroup extends DateDividedAdapter.ItemGroup {
+    public DownloadItemGroup(long timestamp) {
+        super(timestamp);
+    }
+
+    @Override
+    public int compareItem(TimedItem lhs, TimedItem rhs) {
+        int lhsOrder = order(lhs);
+        int rhsOrder = order(rhs);
+
+        if (lhsOrder != rhsOrder) {
+            return lhsOrder < rhsOrder ? -1 : 1;
+        }
+
+        return super.compareItem(lhs, rhs);
+    }
+
+    private boolean isSuggestedOfflinePage(TimedItem timedItem) {
+        if (timedItem instanceof OfflinePageItemWrapper) {
+            return ((OfflinePageItemWrapper) timedItem).isSuggested();
+        }
+
+        return false;
+    }
+
+    private int order(TimedItem timedItem) {

[gone, 2017/02/15 23:58:09]

1) This really needs some documentation about what the return value is and why
it's set that way.
2) This really should be an if / else if / else block instead.

[shaktisahu, 2017/02/16 06:07:06]

Done.

+        if (isSuggestedOfflinePage(timedItem)) return 2;
+        if (timedItem instanceof SubsectionHeader) return 1;
+        return 0;
+    }
+}