chrome/android/java/res/values-v17/styles.xml - Issue 2670083002: [Download Home] Displaying offline page bundle per day

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 2670083002: [Download Home] Displaying offline page bundle per day (Closed)

Patch Set: Filter out pages before adding to DateDividedAdapter Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/android/java/res/layout/offline_download_header.xml ('K') | « chrome/android/java/res/layout/offline_download_header.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <resources xmlns:tools="http://schemas.android.com/tools">	6 <resources xmlns:tools="http://schemas.android.com/tools">

7 <!-- Q: Why put style resources under values-v17/ ?	7 <!-- Q: Why put style resources under values-v17/ ?

8 A: Problem:	8 A: Problem:

9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.	9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.

10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert	10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert

(...skipping 599 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
610 <style name="DownloadHomeStatusText">	610 <style name="DownloadHomeStatusText">

611 <item name="android:layout_width">wrap_content</item>	611 <item name="android:layout_width">wrap_content</item>

612 <item name="android:layout_height">wrap_content</item>	612 <item name="android:layout_height">wrap_content</item>

613 <item name="android:layout_marginTop">0dp</item>	613 <item name="android:layout_marginTop">0dp</item>

614 <item name="android:minHeight">18dp</item>	614 <item name="android:minHeight">18dp</item>

615 <item name="android:textColor">@color/google_grey_600</item>	615 <item name="android:textColor">@color/google_grey_600</item>

616 <item name="android:textSize">12sp</item>1	616 <item name="android:textSize">12sp</item>1

617 <item name="android:ellipsize">start</item>	617 <item name="android:ellipsize">start</item>

618 <item name="android:singleLine">true</item>	618 <item name="android:singleLine">true</item>

619 </style>	619 </style>

	620 <style name="DownloadRowContainer">

	621 <item name="android:layout_width">match_parent</item>

	622 <item name="android:layout_height">wrap_content</item>

	623 <item name="android:layout_marginStart">16dp</item>

	624 <item name="android:layout_marginTop">16dp</item>

	625 <item name="android:layout_marginBottom">16dp</item>

	626 <item name="android:gravity">center_vertical</item>

	627 <item name="android:orientation">horizontal</item>

	628 </style>

	629 <style name="DownloadTitleStyle">

	630 <item name="android:layout_width">wrap_content</item>

	631 <item name="android:layout_height">wrap_content</item>

	632 <item name="android:layout_alignParentTop">true</item>

	633 <item name="android:layout_alignParentStart">true</item>

	634 <item name="android:paddingEnd">16dp</item>

	635 <item name="android:singleLine">true</item>

	636 <item name="android:textColor">@color/default_text_color</item>

	637 <item name="android:textSize">16sp</item>

	638 </style>

	639 <style name="DownloadDescriptionStyle">

	640 <item name="android:layout_width">0dp</item>

	641 <item name="android:layout_height">wrap_content</item>

	642 <item name="android:layout_alignParentBottom">true</item>

	643 <item name="android:layout_alignParentStart">true</item>

	644 <item name="android:layout_marginEnd">16dp</item>

	645 <item name="android:layout_marginTop">0dp</item>

	646 <item name="android:textAlignment">viewStart</item>

	647 <item name="android:textColor">@color/google_grey_600</item>

	648 <item name="android:ellipsize">start</item>

	649 <item name="android:singleLine">true</item>

	650 </style>

	651 <style name="DownloadFileSizeStyle">

	652 <item name="android:layout_width">wrap_content</item>

	653 <item name="android:layout_height">wrap_content</item>

	654 <item name="android:layout_alignParentBottom">true</item>

	655 <item name="android:layout_alignParentEnd">true</item>

	656 <item name="android:layout_marginTop">0dp</item>

	657 <item name="android:paddingEnd">16dp</item>

	658 <item name="android:textAlignment">viewEnd</item>

	659 <item name="android:textColor">@color/google_grey_600</item>

	660 <item name="android:singleLine">true</item>

	661 </style>

	662 <style name="DownloadIconView">

	663 <item name="android:layout_width">@dimen/downloads_item_icon_size</item>

	664 <item name="android:layout_height">@dimen/downloads_item_icon_size</item >

	665 <item name="android:layout_marginEnd">16dp</item>

	666 <item name="android:contentDescription">@null</item>

	667 <item name="android:scaleType">center</item>

	668 <item name="android:background">@color/light_active_color</item>

	669 </style>

620 </resources>	670 </resources>

OLD	NEW