add rounding-using-doubles methods on SkScalar and SkRect

tests/PathTest.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkCanvas.h"
 #include "SkPaint.h"
 #include "SkParse.h"
 #include "SkParsePath.h"
 #include "SkPath.h"
 #include "SkPathEffect.h"
 #include "SkRRect.h"
 #include "SkRandom.h"
 #include "SkReader32.h"
 #include "SkSize.h"
 #include "SkSurface.h"
 #include "SkTypes.h"
 #include "SkWriter32.h"
 #include "Test.h"
 
+static void make_path_crbug364224(SkPath* path) {
+    path->reset();
+    path->moveTo(3.747501373f, 2.724499941f);
+    path->lineTo(3.747501373f, 3.75f);
+    path->cubicTo(3.747501373f, 3.88774991f, 3.635501385f, 4.0f, 3.497501373f, 4.0f);
+    path->lineTo(0.7475013733f, 4.0f);
+    path->cubicTo(0.6095013618f, 4.0f, 0.4975013733f, 3.88774991f, 0.4975013733f, 3.75f);
+    path->lineTo(0.4975013733f, 1.0f);
+    path->cubicTo(0.4975013733f, 0.8622499704f, 0.6095013618f, 0.75f, 0.7475013733f,0.75f);
+    path->lineTo(3.497501373f, 0.75f);
+    path->cubicTo(3.50275135f, 0.75f, 3.5070014f, 0.7527500391f, 3.513001442f, 0.753000021f);
+    path->lineTo(3.715001345f, 0.5512499809f);
+    path->cubicTo(3.648251295f, 0.5194999576f, 3.575501442f, 0.4999999702f, 3.497501373f, 0.4999999702f);
+    path->lineTo(0.7475013733f, 0.4999999702f);
+    path->cubicTo(0.4715013802f, 0.4999999702f, 0.2475013733f, 0.7239999771f, 0.2475013733f, 1.0f);
+    path->lineTo(0.2475013733f, 3.75f);
+    path->cubicTo(0.2475013733f, 4.026000023f, 0.4715013504f, 4.25f, 0.7475013733f, 4.25f);
+    path->lineTo(3.497501373f, 4.25f);
+    path->cubicTo(3.773501396f, 4.25f, 3.997501373f, 4.026000023f, 3.997501373f, 3.75f);
+    path->lineTo(3.997501373f, 2.474750042f);
+    path->lineTo(3.747501373f, 2.724499941f);
+    path->close();
+}
+
+static void make_path_crbug364224_simplified(SkPath* path) {
+    path->moveTo(3.747501373f, 2.724499941f);
+    path->cubicTo(3.648251295f, 0.5194999576f, 3.575501442f, 0.4999999702f, 3.497501373f, 0.4999999702f);
+    path->close();
+}
+
+static void test_path_crbug364224() {
+    SkPath path;
+    SkPaint paint;
+    SkAutoTUnref<SkSurface> surface(SkSurface::NewRasterPMColor(84, 88));
+    SkCanvas* canvas = surface->getCanvas();
+
+    make_path_crbug364224_simplified(&path);
+    canvas->drawPath(path, paint);
+
+    make_path_crbug364224(&path);
+    canvas->drawPath(path, paint);
+}
+
 static void make_path0(SkPath* path) {
     // from  *  https://code.google.com/p/skia/issues/detail?id=1706
 
     path->moveTo(146.939f, 1012.84f);
     path->lineTo(181.747f, 1009.18f);
     path->lineTo(182.165f, 1013.16f);
     path->lineTo(147.357f, 1016.82f);
     path->lineTo(146.939f, 1012.84f);
     path->close();
 }
@@ skipping 3286 matching lines @@
         q.quadTo(6, 7, 8, 6);
         q.cubicTo(5, 6, 7, 8, 7, 5);
         q.close();
         p.reversePathTo(q);
         SkRect reverseExpected = {-4, -4, 8, 8};
         REPORTER_ASSERT(reporter, p.getBounds() == reverseExpected);
     }
 };
 
 DEF_TEST(Paths, reporter) {
+    test_path_crbug364224();
+
     SkTSize<SkScalar>::Make(3,4);
 
     SkPath  p, empty;
     SkRect  bounds, bounds2;
     test_empty(reporter, p);
 
     REPORTER_ASSERT(reporter, p.getBounds().isEmpty());
 
     // this triggers a code path in SkPath::operator= which is otherwise unexercised
     SkPath& self = p;
@@ skipping 106 matching lines @@
     test_addPathMode(reporter, true, true);
     test_extendClosedPath(reporter);
     test_addEmptyPath(reporter, SkPath::kExtend_AddPathMode);
     test_addEmptyPath(reporter, SkPath::kAppend_AddPathMode);
     test_conicTo_special_case(reporter);
     test_get_point(reporter);
     test_contains(reporter);
     PathTest_Private::TestPathTo(reporter);
     PathRefTest_Private::TestPathRef(reporter);
 }