LTTF: Print the element path in TestWebViewDelegate::decidePolicyForNavigation()...

Print the element path in TestWebViewDelegate::decidePolicyForNavigation()
to follow WebKit r42740.

- Add a WebNode parameter to WebViewDelegate::decidePolicyForNavigation()
  TestWebViewDelegate prints the path of the node.  RenderView ignores this parameter.

- Fix a bug of WebNode assignment.

BUG=11000
TEST=This change enables 3 layout tests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28527

[darin (slow to review), 2009-10-08 16:55:44]

http://codereview.chromium.org/267003/diff/1/6
File webkit/api/public/WebFrameClient.h (right):

http://codereview.chromium.org/267003/diff/1/6#newcode90
Line 90: WebFrame*, const WebURLRequest&, WebNavigationType, const WebNode&,
please name this parameter.  it is not obvious what it refers to.  elsewhere,
you call it the originatingNode.  can you define that?

http://codereview.chromium.org/267003/diff/1/5
File webkit/api/src/WebNode.cpp (right):

http://codereview.chromium.org/267003/diff/1/5#newcode52
Line 52: if (p)
oops!  can you please check the other similar classes in webkit/api/src to see
if they need the same fix?

http://codereview.chromium.org/267003/diff/1/7
File webkit/glue/empty_webframeclient.h (right):

http://codereview.chromium.org/267003/diff/1/7#newcode30
Line 30: WebKit::WebNavigationType type, const WebKit::WebNode& originatingNode,
nit: please use google style in this file.

http://codereview.chromium.org/267003/diff/1/8
File webkit/glue/webframeloaderclient_impl.cc (right):

http://codereview.chromium.org/267003/diff/1/8#newcode841
Line 841: WebNode webNode = webkit_glue::NodeToWebNode(node);
nit: please use google style.  webNode -> webnode, mouseEvent -> mouse_event,
etc.

[tkent, 2009-10-09 02:12:14]

http://codereview.chromium.org/267003/diff/1/6
File webkit/api/public/WebFrameClient.h (right):

http://codereview.chromium.org/267003/diff/1/6#newcode90
Line 90: WebFrame*, const WebURLRequest&, WebNavigationType, const WebNode&,
On 2009/10/08 16:55:45, darin wrote:
> please name this parameter.  it is not obvious what it refers to.  elsewhere,
> you call it the originatingNode.  can you define that?

Done.

http://codereview.chromium.org/267003/diff/1/5
File webkit/api/src/WebNode.cpp (right):

http://codereview.chromium.org/267003/diff/1/5#newcode52
Line 52: if (p)
On 2009/10/08 16:55:45, darin wrote:
> oops!  can you please check the other similar classes in webkit/api/src to see
> if they need the same fix?

I found other 8 instances.  I'll fix them in another CL.

http://codereview.chromium.org/267003/diff/1/7
File webkit/glue/empty_webframeclient.h (right):

http://codereview.chromium.org/267003/diff/1/7#newcode30
Line 30: WebKit::WebNavigationType type, const WebKit::WebNode& originatingNode,
On 2009/10/08 16:55:45, darin wrote:
> nit: please use google style in this file.

Done.

http://codereview.chromium.org/267003/diff/1/8
File webkit/glue/webframeloaderclient_impl.cc (right):

http://codereview.chromium.org/267003/diff/1/8#newcode841
Line 841: WebNode webNode = webkit_glue::NodeToWebNode(node);
On 2009/10/08 16:55:45, darin wrote:
> nit: please use google style.  webNode -> webnode, mouseEvent -> mouse_event,
> etc.

Done.

[darin (slow to review), 2009-10-09 04:11:56]

LGTM