Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 267003: LTTF: Print the element path in TestWebViewDelegate::decidePolicyForNavigation()... (Closed)

Created:
11 years, 2 months ago by tkent
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, jam, pam+watch_chromium.org
Visibility:
Public.

Description

Print the element path in TestWebViewDelegate::decidePolicyForNavigation() to follow WebKit r42740. - Add a WebNode parameter to WebViewDelegate::decidePolicyForNavigation() TestWebViewDelegate prints the path of the node. RenderView ignores this parameter. - Fix a bug of WebNode assignment. BUG=11000 TEST=This change enables 3 layout tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28527

Patch Set 1 #

Total comments: 8

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -108 lines) Patch
M chrome/renderer/render_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/api/public/WebFrameClient.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/api/src/WebNode.cpp View 1 chunk +91 lines, -90 lines 0 comments Download
M webkit/glue/empty_webframeclient.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webframeloaderclient_impl.cc View 1 2 4 chunks +18 lines, -2 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +2 lines, -8 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 2 3 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
11 years, 2 months ago (2009-10-08 12:03:24 UTC) #1
darin (slow to review)
http://codereview.chromium.org/267003/diff/1/6 File webkit/api/public/WebFrameClient.h (right): http://codereview.chromium.org/267003/diff/1/6#newcode90 Line 90: WebFrame*, const WebURLRequest&, WebNavigationType, const WebNode&, please name ...
11 years, 2 months ago (2009-10-08 16:55:44 UTC) #2
tkent
http://codereview.chromium.org/267003/diff/1/6 File webkit/api/public/WebFrameClient.h (right): http://codereview.chromium.org/267003/diff/1/6#newcode90 Line 90: WebFrame*, const WebURLRequest&, WebNavigationType, const WebNode&, On 2009/10/08 ...
11 years, 2 months ago (2009-10-09 02:12:14 UTC) #3
darin (slow to review)
11 years, 2 months ago (2009-10-09 04:11:56 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698