Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: net/http/http_response_headers.h

Issue 2670013002: net: remove GetNormalizedHeaders() function (Closed)
Patch Set: n Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_cache_unittest.cc ('k') | net/http/http_response_headers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_response_headers.h
diff --git a/net/http/http_response_headers.h b/net/http/http_response_headers.h
index e45fe05db5528fdcbd9c1d6088aab089cdc96b30..167980df25c976bbfcfdc8a013154fa78d1cf8ca 100644
--- a/net/http/http_response_headers.h
+++ b/net/http/http_response_headers.h
@@ -119,30 +119,6 @@ class NET_EXPORT HttpResponseHeaders
int64_t resource_size,
bool replace_status_line);
- // Creates a normalized header string. The output will be formatted exactly
- // like so:
- // HTTP/<version> <status_code>[ <status_text>]\n
- // [<header-name>: <header-values>\n]*
- // meaning, each line is \n-terminated, and there is no extra whitespace
- // beyond the single space separators shown (of course, values can contain
- // whitespace within them). If a given header-name appears more than once
- // in the set of headers, they are combined into a single line like so:
- // <header-name>: <header-value1>, <header-value2>, ...<header-valueN>\n
- //
- // DANGER: For some headers (e.g., "Set-Cookie"), the normalized form can be
- // a lossy format. This is due to the fact that some servers generate
- // Set-Cookie headers that contain unquoted commas (usually as part of the
- // value of an "expires" attribute). So, use this function with caution. Do
- // not expect to be able to re-parse Set-Cookie headers from this output.
- //
- // NOTE: Do not make any assumptions about the encoding of this output
- // string. It may be non-ASCII, and the encoding used by the server is not
- // necessarily known to us. Do not assume that this output is UTF-8!
- //
- // TODO(darin): remove this method
- //
- void GetNormalizedHeaders(std::string* output) const;
-
// Fetch the "normalized" value of a single header, where all values for the
// header name are separated by commas. See the GetNormalizedHeaders for
// format details. Returns false if this header wasn't found.
« no previous file with comments | « net/http/http_cache_unittest.cc ('k') | net/http/http_response_headers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698