Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 2670003002: Accessibility for Autofill Popup View in native code (Closed)
Patch Set: Removes call to RequestFocus. RequestFocus fails because the widget is not active. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
index dcf42475ce7723add5e3f6d31b9f63143d3fe475..cc98ae5df8cd2dfd654f5161c1831dd104364061 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
@@ -401,8 +401,12 @@ void AutofillPopupControllerImpl::SetSelectedLine(int selected_line) {
if (selected_line != kNoSelection) {
InvalidateRow(selected_line);
- if (!CanAccept(suggestions_[selected_line].frontend_id))
+ if (CanAccept(suggestions_[selected_line].frontend_id)) {
+ view_->NotifyAccessibilityEventForRow(ui::AX_EVENT_SELECTION,
+ selected_line);
+ } else {
selected_line = kNoSelection;
+ }
}
selected_line_ = selected_line;

Powered by Google App Engine
This is Rietveld 408576698