Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: tests/html/custom/created_callback_test.dart

Issue 26700003: Test fixes for CustomElement upgrade changes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/html/custom/created_callback_test.dart
diff --git a/tests/html/custom/created_callback_test.dart b/tests/html/custom/created_callback_test.dart
index d94e006441b34f96303566a4743ad8d4161ce9e3..1ca50fdf24a2e9ff700c6ad869eb71110dcd536e 100644
--- a/tests/html/custom/created_callback_test.dart
+++ b/tests/html/custom/created_callback_test.dart
@@ -147,9 +147,8 @@ main() {
expect(e is ErrorConstructorElement, isFalse);
});
- // Issue - 13711 Need to fix the handling of the created constructor.
- // test('created cannot be called from nested constructor',
- // NestedCreatedConstructorElement.test);
+ test('created cannot be called from nested constructor',
+ NestedCreatedConstructorElement.test);
// TODO(vsm): Port additional test from upstream here:
@@ -263,7 +262,10 @@ class NestedCreatedConstructorElement extends HtmlElement {
register();
// Exception should have occurred on upgrade.
- var e = new Element.tag(tag);
+ var e;
+ expectGlobalError(() {
+ e = new Element.tag(tag);
+ });
expect(e is NestedCreatedConstructorElement, isFalse);
expect(e is HtmlElement, isTrue);
// Should not have been set.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698