Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 266993003: base: Increase emulated discardable memory limit. (Closed)

Created:
6 years, 7 months ago by reveman
Modified:
6 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Visibility:
Public.

Description

base: Increase emulated discardable memory limit. This increases the limit to 128MB but keeps the limit under moderate pressure low so the total amount of memory used by chrome is not significantly increased. BUG=368078 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M base/memory/discardable_memory_manager.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
reveman
6 years, 7 months ago (2014-05-05 21:39:50 UTC) #1
willchan no longer on Chromium
LGTM from a base/OWNERS perspective. To be honest, I'm not super well qualified to evaluate ...
6 years, 7 months ago (2014-05-05 21:46:37 UTC) #2
reveman
6 years, 7 months ago (2014-05-05 22:02:21 UTC) #3
enne (OOO)
Since this increase is just for the active tab, that doesn't seem unreasonable. lgtm, not ...
6 years, 7 months ago (2014-05-05 22:11:05 UTC) #4
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 7 months ago (2014-05-05 22:14:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/266993003/1
6 years, 7 months ago (2014-05-05 22:15:13 UTC) #6
commit-bot: I haz the power
Change committed as 268371
6 years, 7 months ago (2014-05-06 01:55:00 UTC) #7
Philippe
6 years, 7 months ago (2014-05-06 08:08:52 UTC) #8
Message was sent while issue was closed.
On 2014/05/06 01:55:00, I haz the power (commit-bot) wrote:
> Change committed as 268371

Lgtm. I believe David has his other MacOS patch that moves the hard-coded
constant out of the manager. The 128 MBytes limit looks reasonable to me
although those things are pretty empirical in general.

Powered by Google App Engine
This is Rietveld 408576698