Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 26699002: Add new GM to stress test the GPU font cache for cases similar to (Closed)

Created:
7 years, 2 months ago by jvanverth1
Modified:
7 years, 2 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add new GM to stress test the GPU font cache for cases similar to Chromium issue 303803. BUG=303803 Committed: http://code.google.com/p/skia/source/detail?r=11673 Committed: http://code.google.com/p/skia/source/detail?r=11680

Patch Set 1 #

Patch Set 2 : Rebase to HEAD #

Total comments: 9

Patch Set 3 : Address nits/questions #

Patch Set 4 : Fix Windows warning; initialize fTypefaces[] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -0 lines) Patch
A gm/fontcache.cpp View 1 2 3 1 chunk +121 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jvanverth1
7 years, 2 months ago (2013-10-09 15:13:23 UTC) #1
robertphillips
lgtm + nits & questions https://codereview.chromium.org/26699002/diff/5001/gm/fontcache.cpp File gm/fontcache.cpp (right): https://codereview.chromium.org/26699002/diff/5001/gm/fontcache.cpp#newcode22 gm/fontcache.cpp:22: Is "20" missing on ...
7 years, 2 months ago (2013-10-09 15:23:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/26699002/11001
7 years, 2 months ago (2013-10-09 15:50:45 UTC) #3
commit-bot: I haz the power
Change committed as 11673
7 years, 2 months ago (2013-10-09 16:00:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/26699002/18001
7 years, 2 months ago (2013-10-09 18:01:19 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 18:12:27 UTC) #6
Message was sent while issue was closed.
Change committed as 11680

Powered by Google App Engine
This is Rietveld 408576698